Thanks, Yu Xin for the patch set! I just have some comments: 1) On new template dialog, name the new option as "Local image file" instead of "Local VM Image" 2) On edit template view, name it as "Image file" instead of "VM image" 3) The input box style differs from Kimchi style. It needs to have rounded border 4) When selecting "Create" it takes too much time to finish the request - it is because the backend checks the image file prior to create the template. So I suggest to when selecting "Create" change it to "Creating..." (as we need on network tab) with disabled style. And once you get the server response you close the dialog. On 09/04/2014 07:04 AM, huoyuxin@linux.vnet.ibm.com wrote:
From: Yu Xin Huo <huoyuxin@linux.vnet.ibm.com>
Yu Xin Huo (3): UI: Template with VM Image - Create UI: Template with VM Image - Edit UI: Template with VM Image - List
ui/css/theme-default/form.css | 13 ++++++++----- ui/css/theme-default/template_add.css | 18 ++++++++++++++++++ ui/js/src/kimchi.template_add_main.js | 17 +++++++++++++++++ ui/js/src/kimchi.template_edit_main.js | 8 ++++++++ ui/js/src/kimchi.template_main.js | 12 +++++++++++- ui/pages/template-add.html.tmpl | 13 +++++++++++++ ui/pages/template-edit.html.tmpl | 6 +++++- 7 files changed, 80 insertions(+), 7 deletions(-)
_______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel