[PATCH v2] Fix text alignment on storage pool type combo boxes

The storage pool type list does not have a left padding like the other combo boxes in Kimchi, bringing the text very close to the UI component's border. The SCSI device list on the same window has the same alignment problem. Apply a common CSS class to the combo boxes so they look like the other objects in the application. Signed-off-by: Crístian Viana <vianac@linux.vnet.ibm.com> --- ui/pages/storagepool-add.html.tmpl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/pages/storagepool-add.html.tmpl b/ui/pages/storagepool-add.html.tmpl index 977db66..ba85e6e 100644 --- a/ui/pages/storagepool-add.html.tmpl +++ b/ui/pages/storagepool-add.html.tmpl @@ -44,7 +44,7 @@ <div class="storage-type-wrapper-controls"> <div id="poolTypeId"> <input id="poolTypeInputId" name="type" type="hidden" value="dir"/> - <span id="pool-type-label"></span><span class="arrow"></span> + <span id="pool-type-label" class="text"></span><span class="arrow"></span> <div> <ul id="storagePool-list"> </ul> @@ -142,7 +142,7 @@ <div class="storage-type-wrapper-controls"> <div id="scsiAdapter"> <input type="hidden"/> - <span></span><span class="arrow"></span> + <span class="text"></span><span class="arrow"></span> <div><ul></ul></div> </div> </div> -- 1.9.0

On 05/14/2014 08:27 AM, Crístian Viana wrote:
The storage pool type list does not have a left padding like the other combo boxes in Kimchi, bringing the text very close to the UI component's border. The SCSI device list on the same window has the same alignment problem.
Apply a common CSS class to the combo boxes so they look like the other objects in the application.
Signed-off-by: Crístian Viana <vianac@linux.vnet.ibm.com> Reviewed-by: Hongliang Wang <hlwang@linux.vnet.ibm.com> --- ui/pages/storagepool-add.html.tmpl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/pages/storagepool-add.html.tmpl b/ui/pages/storagepool-add.html.tmpl index 977db66..ba85e6e 100644 --- a/ui/pages/storagepool-add.html.tmpl +++ b/ui/pages/storagepool-add.html.tmpl @@ -44,7 +44,7 @@ <div class="storage-type-wrapper-controls"> <div id="poolTypeId"> <input id="poolTypeInputId" name="type" type="hidden" value="dir"/> - <span id="pool-type-label"></span><span class="arrow"></span> + <span id="pool-type-label" class="text"></span><span class="arrow"></span> <div> <ul id="storagePool-list"> </ul> @@ -142,7 +142,7 @@ <div class="storage-type-wrapper-controls"> <div id="scsiAdapter"> <input type="hidden"/> - <span></span><span class="arrow"></span> + <span class="text"></span><span class="arrow"></span> <div><ul></ul></div> </div> </div>

Reviewed-by: ShaoHe Feng <shaohef@linux.vnet.ibm.com> Tested-by: ShaoHe Feng <shaohef@linux.vnet.ibm.com> On 05/14/2014 08:27 AM, Crístian Viana wrote:
The storage pool type list does not have a left padding like the other combo boxes in Kimchi, bringing the text very close to the UI component's border. The SCSI device list on the same window has the same alignment problem.
Apply a common CSS class to the combo boxes so they look like the other objects in the application.
Signed-off-by: Crístian Viana <vianac@linux.vnet.ibm.com> --- ui/pages/storagepool-add.html.tmpl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/pages/storagepool-add.html.tmpl b/ui/pages/storagepool-add.html.tmpl index 977db66..ba85e6e 100644 --- a/ui/pages/storagepool-add.html.tmpl +++ b/ui/pages/storagepool-add.html.tmpl @@ -44,7 +44,7 @@ <div class="storage-type-wrapper-controls"> <div id="poolTypeId"> <input id="poolTypeInputId" name="type" type="hidden" value="dir"/> - <span id="pool-type-label"></span><span class="arrow"></span> + <span id="pool-type-label" class="text"></span><span class="arrow"></span> <div> <ul id="storagePool-list"> </ul> @@ -142,7 +142,7 @@ <div class="storage-type-wrapper-controls"> <div id="scsiAdapter"> <input type="hidden"/> - <span></span><span class="arrow"></span> + <span class="text"></span><span class="arrow"></span> <div><ul></ul></div> </div> </div>
-- Thanks and best regards! Sheldon Feng(冯少合)<shaohef@linux.vnet.ibm.com> IBM Linux Technology Center
participants (4)
-
Aline Manera
-
Crístian Viana
-
Hongliang Wang
-
Sheldon