[RFC]: for template cloning.

template cloning: <https://github.com/kimchi-project/kimchi/wiki/template-cloning-and-customization#wiki-template-cloning> |1|||clone a template| from|||template| The user may clone a template from an existing template with different name. Later he can customize some parts of the template to save the effort to create a full new template. For example, he can update the network of the template cloned to have a new different template. 2.||we should also also user||||clone a template| from vm| |I just concern the image volume. For vm may has no CDROM attribute. Then does the template need to copy the image volume. |For VM clone, can we make the the vm image as a backing file(or we can call it base image). Then we can create two new images for this vm and new vm. All these two new images are a read/write snapshot of the original image, -- any changes to new images will not be reflected in original image. http://libvirt.org/formatstorage.html#StorageVolBacking http://wiki.qemu.org/Documentation/CreateSnapshot | -- Thanks and best regards! Sheldon Feng(???)<shaohef@linux.vnet.ibm.com> IBM Linux Technology Center

Sheldon, looks good your RFC. There's an issue opened to Template cloning on github: https://github.com/kimchi-project/kimchi/issues/196 Best regards, -- Paulo Ricardo Paz Vital <pvital@linux.vnet.ibm.com> IBM Linux Technology Center On Tue, 2014-01-28 at 23:11 +0800, Sheldon wrote:
template cloning: 1 clone a template from template The user may clone a template from an existing template with different name. Later he can customize some parts of the template to save the effort to create a full new template. For example, he can update the network of the template cloned to have a new different template.
2. we should also also user clone a template from vm I just concern the image volume. For vm may has no CDROM attribute. Then does the template need to copy the image volume. For VM clone, can we make the the vm image as a backing file(or we can call it base image).
Then we can create two new images for this vm and new vm.
All these two new images are a read/write snapshot of the original image,
-- any changes to new images will not be reflected in original image.
http://libvirt.org/formatstorage.html#StorageVolBacking
http://wiki.qemu.org/Documentation/CreateSnapshot
-- Thanks and best regards!
Sheldon Feng(冯少合)<shaohef@linux.vnet.ibm.com> IBM Linux Technology Center _______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel

Sheldon, looks good your RFC. There's an issue opened to Template cloning on github: https://github.com/kimchi-project/kimchi/issues/196
On 01/29/2014 09:15 PM, Paulo Ricardo Paz Vital wrote: pvital, thanks. There is a issue about it. and you take this issue. but, the plan1.2 sprint 3 assign to me. https://github.com/kimchi-project/kimchi/wiki/Todo-1.2#wiki-12-sprint-3-ends... so sorry. Not sure you will still take this task. If you take, I can do code review for your patch.:-)
Best regards,
-- Thanks and best regards! Sheldon Feng(冯少合)<shaohef@linux.vnet.ibm.com> IBM Linux Technology Cente

On 1/28/2014 10:11 AM, Sheldon wrote:
template cloning: <https://github.com/kimchi-project/kimchi/wiki/template-cloning-and-customization#wiki-template-cloning>
|1|||clone a template| from|||template| The user may clone a template from an existing template with different name. Later he can customize some parts of the template to save the effort to create a full new template. For example, he can update the network of the template cloned to have a new different template.|
|Can we provide a reasonable default the name of the clone|? With the full edit flow in place, its tempting to just add a "duplicate template" action to template. The action default everything in the new template.
|
2.||we should also also user||||clone a template| from vm| |I just concern the image volume. For vm may has no CDROM attribute. Then does the template need to copy the image volume. |For VM clone, can we make the the vm image as a backing file(or we can call it base image).
Then we can create two new images for this vm and new vm.
All these two new images are a read/write snapshot of the original image,
-- any changes to new images will not be reflected in original image.
http://libvirt.org/formatstorage.html#StorageVolBacking
http://wiki.qemu.org/Documentation/CreateSnapshot | Section 2 of the RFC gets very interesting, but somewhat more complicated than clone template. I suggest we treat this scenario as a create template scenario, and separately from clone template.
| | -- Thanks and best regards!
Sheldon Feng(???)<shaohef@linux.vnet.ibm.com> IBM Linux Technology Center
_______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel
-- Adam King <rak@linux.vnet.ibm.com> IBM CSI

On 01/29/2014 11:06 PM, Adam King wrote:
On 1/28/2014 10:11 AM, Sheldon wrote:
template cloning: <https://github.com/kimchi-project/kimchi/wiki/template-cloning-and-customization#wiki-template-cloning>
|1|||clone a template| from|||template| The user may clone a template from an existing template with different name. Later he can customize some parts of the template to save the effort to create a full new template. For example, he can update the network of the template cloned to have a new different template.|
|Can we provide a reasonable default the name of the clone|?
With the full edit flow in place, its tempting to just add a "duplicate template" action to template. The action default everything in the new template. Do you means we let the user pre-edit the template. for if user want to clone a template with name "template1", but he just want a CPU numbers are different. He just modify the current template( "template1") , and press "clone",
How about we set the default name of the clone as follow? if the template name is "kimchi-template", then the default name is "kimchi-template-clone1". and user will clone this template twice, then the default name is "kimchi-template-clone2". then kimchi generate "template1-clone1" template. We will not save the "template1" what he modify. and all the attributes of new "template1-clone1" template are same with "template1" except name and CPU number. Right? of course, the user can modify the CPU number after he does clone.
|
2.||we should also also user||||clone a template| from vm| |I just concern the image volume. For vm may has no CDROM attribute. Then does the template need to copy the image volume. |For VM clone, can we make the the vm image as a backing file(or we can call it base image).
Then we can create two new images for this vm and new vm.
All these two new images are a read/write snapshot of the original image,
-- any changes to new images will not be reflected in original image.
http://libvirt.org/formatstorage.html#StorageVolBacking
http://wiki.qemu.org/Documentation/CreateSnapshot | Section 2 of the RFC gets very interesting, but somewhat more complicated than clone template. I suggest we treat this scenario as a create template scenario, and separately from clone template. ACK
| | -- Thanks and best regards!
Sheldon Feng(???)<shaohef@linux.vnet.ibm.com> IBM Linux Technology Center
_______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel
-- Adam King<rak@linux.vnet.ibm.com> IBM CSI
_______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel
-- Thanks and best regards! Sheldon Feng(???)<shaohef@linux.vnet.ibm.com> IBM Linux Technology Center

On 01/28/2014 01:11 PM, Sheldon wrote:
template cloning: <https://github.com/kimchi-project/kimchi/wiki/template-cloning-and-customization#wiki-template-cloning>
|1|||clone a template| from|||template| The user may clone a template from an existing template with different name. Later he can customize some parts of the template to save the effort to create a full new template. For example, he can update the network of the template cloned to have a new different template.
|
ACK
| 2.||we should also also user||||clone a template| from vm| |I just concern the image volume. For vm may has no CDROM attribute. Then does the template need to copy the image volume. |For VM clone, can we make the the vm image as a backing file(or we can call it base image).
Then we can create two new images for this vm and new vm.
All these two new images are a read/write snapshot of the original image,
-- any changes to new images will not be reflected in original image.
For this second item, there is a specific item for sprint 4 "(alinefm) Create template from VM" And I've already sent a patch for it long time ago: https://groups.google.com/forum/#!msg/project-kimchi/YR6ewAwFaEA/ZsaU4En7jlU... For sprint 3, I think we can focus only on item 1, which is the template clone itself.
| | -- Thanks and best regards!
Sheldon Feng(???)<shaohef@linux.vnet.ibm.com> IBM Linux Technology Center
_______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel
participants (4)
-
Adam King
-
Aline Manera
-
Paulo Ricardo Paz Vital
-
Sheldon