[PATCH] [Kimchi] Bugfix 778: Add volume freezes screen
This patch fixes the screen freezing when adding a storage volume via upload file. The problem was that the item being retrieved from the array was the wrong one since the path has changed. In addition, the modal window is now being closed rather than hidden. That is the reason why the screen seems to be frozen. Socorro Stoppler (1): Fix screen freezing when upload file for storage volume ui/js/src/kimchi.storage_main.js | 6 +++--- ui/js/src/kimchi.storagepool_add_volume_main.js | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) -- 1.9.1
Signed-off-by: Socorro Stoppler <socorro@linux.vnet.ibm.com> --- ui/js/src/kimchi.storage_main.js | 6 +++--- ui/js/src/kimchi.storagepool_add_volume_main.js | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ui/js/src/kimchi.storage_main.js b/ui/js/src/kimchi.storage_main.js index 29ee365..1a711ce 100644 --- a/ui/js/src/kimchi.storage_main.js +++ b/ui/js/src/kimchi.storage_main.js @@ -450,7 +450,7 @@ kimchi.storage_main = function() { }; var uriElements = result.target_uri.split('/'); - var poolName = uriElements[2]; + var poolName = uriElements[4]; var volumeName = uriElements.pop(); var progress = extractProgressData(result['message']); var size = progress['size']; @@ -467,7 +467,7 @@ kimchi.storage_main = function() { wok.topic('kimchi/volumeTransferFinished').subscribe(function(result) { var uriElements = result.target_uri.split('/'); - var poolName = uriElements[2]; + var poolName = uriElements[4]; var volumeName = uriElements.pop(); var volumeBox = $('#volume' + poolName + ' [data-volume-name="' + volumeName + '"]'); $('.volume-progress', volumeBox).addClass('hidden'); @@ -491,7 +491,7 @@ kimchi.storage_main = function() { result && wok.message.error(errText); var uriElements = result.target_uri.split('/'); - var poolName = uriElements[2]; + var poolName = uriElements[4]; var volumeName = uriElements.pop(); volumeBox = $('#volume' + poolName + ' [data-volume-name="' + volumeName + '"]'); $('.progress-status', volumeBox).text(i18n['KCHPOOL6015M']); diff --git a/ui/js/src/kimchi.storagepool_add_volume_main.js b/ui/js/src/kimchi.storagepool_add_volume_main.js index d13977d..a1a8306 100644 --- a/ui/js/src/kimchi.storagepool_add_volume_main.js +++ b/ui/js/src/kimchi.storagepool_add_volume_main.js @@ -175,6 +175,6 @@ kimchi.sp_add_volume_main = function() { uploadFile(); } event.preventDefault(); - $('#modalWindow').modal("hide"); + $('#modalWindow').modal.close(); }); }; -- 1.9.1
Reviewed-by: Rodrigo Trujillo <rodrigo.trujillo@linux.vnet.ibm.com> Tested-by: Rodrigo Trujillo <rodrigo.trujillo@linux.vnet.ibm.com> This patch fixes the problem I reported in #778 and can be applied, because it is UI. However I have seen some issues, that should be caused by backend (download stops when change tab). I need to dig deeper. On 12/10/2015 06:23 PM, Socorro Stoppler wrote:
This patch fixes the screen freezing when adding a storage volume via upload file. The problem was that the item being retrieved from the array was the wrong one since the path has changed.
In addition, the modal window is now being closed rather than hidden. That is the reason why the screen seems to be frozen.
Socorro Stoppler (1): Fix screen freezing when upload file for storage volume
ui/js/src/kimchi.storage_main.js | 6 +++--- ui/js/src/kimchi.storagepool_add_volume_main.js | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-)
Applied. Thanks. Regards, Aline Manera
participants (3)
-
Aline Manera -
Rodrigo Trujillo -
Socorro Stoppler