--Apple-Mail=_B5E3106A-94F6-40B0-A9A6-4DD310F17BA3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8
On 7 Oct 2016, at 15:28, Simone Tiraboschi <stirabos@redhat.com> = wrote: =20 =20 =20 On Fri, Oct 7, 2016 at 3:25 PM, Michal Skrivanek = <michal.skrivanek@redhat.com <mailto:michal.skrivanek@redhat.com>> = wrote: =20
On 7 Oct 2016, at 14:59, Nir Soffer <nsoffer@redhat.com = <mailto:nsoffer@redhat.com>> wrote: =20 On Fri, Oct 7, 2016 at 3:52 PM, Michal Skrivanek = <michal.skrivanek@redhat.com <mailto:michal.skrivanek@redhat.com>> = wrote: =20
On 7 Oct 2016, at 14:42, Nir Soffer <nsoffer@redhat.com = <mailto:nsoffer@redhat.com>> wrote: =20 On Wed, Oct 5, 2016 at 1:33 PM, Simone Tiraboschi = <stirabos@redhat.com <mailto:stirabos@redhat.com>> wrote: =20 =20 On Wed, Oct 5, 2016 at 10:34 AM, Nir Soffer <nsoffer@redhat.com = <mailto:nsoffer@redhat.com>> wrote: On Wed, Oct 5, 2016 at 10:24 AM, Simone Tiraboschi = <stirabos@redhat.com <mailto:stirabos@redhat.com>> wrote: =20 =20 On Wed, Oct 5, 2016 at 9:17 AM, gregor <gregor_forum@catrix.at = <mailto:gregor_forum@catrix.at>> wrote: Hi, =20 did you found a solution or cause for this high CPU usage? I have installed the self hosted engine on another server and there = is no VM running but ovirt-ha-agent uses heavily the CPU. =20 Yes, it's due to the fact that ovirt-ha-agent periodically = reconnects over json rpc and this is CPU intensive since the client has = to parse the yaml API specification each time it connects. =20 wasn=E2=80=99t it suppose to be fixed to reuse the connection? Like = all the other clients (vdsm migration code:-)=20 =20 This is orthogonal issue. =20 Yes it is. And that=E2=80=99s the issue;-) Both are wrong, but by =E2=80=9Cfixing=E2=80=9D the schema validation = only you lose the motivation to fix the meaningless wasteful reconnect =20 Yes, we are going to fix that too ( = https://bugzilla.redhat.com/show_bug.cgi?id=3D1349829 = <https://bugzilla.redhat.com/show_bug.cgi?id=3D1349829> )
that=E2=80=99s great! Also al the other vdsClient uses?:-) What is that periodic one call anyway? Is there only one? Maybe we = don=E2=80=99t need it so much.
but it would require also = https://bugzilla.redhat.com/show_bug.cgi?id=3D1376843 = <https://bugzilla.redhat.com/show_bug.cgi?id=3D1376843> to be fixed.
=20 =20
=20 Does schema validation matter then if there would be only one = connection at the start up? =20 Loading once does not help command line tools like vdsClient, = hosted-engine and vdsm-tool.=20 =20 none of the other tools is using json-rpc. =20 hosted-engine-setup is, and sooner or later we'll have to migrate also =
=20 =20
=20 Nir =20 =20
=20 Simone, reusing the connection is good idea anyway, but what you = describe is=20 a bug in the client library. The library does *not* need to load and =
schema at all for sending requests to vdsm. =20 The schema is only needed if you want to verify request parameters, or provide online help, these are not needed in a client library. =20 Please file an infra bug about it. =20 Done, https://bugzilla.redhat.com/show_bug.cgi?id=3D1381899 = <https://bugzilla.redhat.com/show_bug.cgi?id=3D1381899> =20 Here is a patch that should eliminate most most of the problem: https://gerrit.ovirt.org/65230 <https://gerrit.ovirt.org/65230> =20 Would be nice if it can be tested on the system showing this =
This is less good. Well, worst case you can reconnect yourself, all you = need is a notification when the existing connection breaks the remaining tools since xmlrpc has been deprecated with 4.0 ok. though setup is a one-time action so it=E2=80=99s not an issue there parse the problem.
=20 Cheers, Nir _______________________________________________ Users mailing list Users@ovirt.org <mailto:Users@ovirt.org> http://lists.ovirt.org/mailman/listinfo/users = <http://lists.ovirt.org/mailman/listinfo/users> =20 =20
Users mailing list Users@ovirt.org <mailto:Users@ovirt.org> http://lists.ovirt.org/mailman/listinfo/users = <http://lists.ovirt.org/mailman/listinfo/users> =20 =20
Users mailing list Users@ovirt.org <mailto:Users@ovirt.org> http://lists.ovirt.org/mailman/listinfo/users = <http://lists.ovirt.org/mailman/listinfo/users> =20 =20 _______________________________________________ Users mailing list Users@ovirt.org http://lists.ovirt.org/mailman/listinfo/users
<div class=3D""><br class=3D""></div><div class=3D"">Here is a patch =
--Apple-Mail=_B5E3106A-94F6-40B0-A9A6-4DD310F17BA3 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html = charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" = class=3D""><br class=3D""><div><blockquote type=3D"cite" class=3D""><div = class=3D"">On 7 Oct 2016, at 15:28, Simone Tiraboschi <<a = href=3D"mailto:stirabos@redhat.com" class=3D"">stirabos@redhat.com</a>>= wrote:</div><br class=3D"Apple-interchange-newline"><div class=3D""><div = dir=3D"ltr" class=3D""><br class=3D""><div class=3D"gmail_extra"><br = class=3D""><div class=3D"gmail_quote">On Fri, Oct 7, 2016 at 3:25 PM, = Michal Skrivanek <span dir=3D"ltr" class=3D""><<a = href=3D"mailto:michal.skrivanek@redhat.com" target=3D"_blank" = class=3D"">michal.skrivanek@redhat.com</a>></span> wrote:<br = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px = 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div = style=3D"word-wrap:break-word" class=3D""><br class=3D""><div = class=3D""><span class=3D"gmail-"><blockquote type=3D"cite" = class=3D""><div class=3D"">On 7 Oct 2016, at 14:59, Nir Soffer <<a = href=3D"mailto:nsoffer@redhat.com" target=3D"_blank" = class=3D"">nsoffer@redhat.com</a>> wrote:</div><br class=3D""><div = class=3D""><div dir=3D"ltr" class=3D""><div class=3D"gmail_extra"><div = class=3D"gmail_quote">On Fri, Oct 7, 2016 at 3:52 PM, Michal Skrivanek = <span dir=3D"ltr" class=3D""><<a = href=3D"mailto:michal.skrivanek@redhat.com" target=3D"_blank" = class=3D"">michal.skrivanek@redhat.com</a>></span> wrote:<br = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px = 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div = style=3D"word-wrap:break-word" class=3D""><br class=3D""><div = class=3D""><span class=3D""><blockquote type=3D"cite" class=3D""><div = class=3D"">On 7 Oct 2016, at 14:42, Nir Soffer <<a = href=3D"mailto:nsoffer@redhat.com" target=3D"_blank" = class=3D"">nsoffer@redhat.com</a>> wrote:</div><br class=3D""><div = class=3D""><div dir=3D"ltr" class=3D""><div class=3D"gmail_extra"><div = class=3D"gmail_quote">On Wed, Oct 5, 2016 at 1:33 PM, Simone Tiraboschi = <span dir=3D"ltr" class=3D""><<a href=3D"mailto:stirabos@redhat.com" = target=3D"_blank" class=3D"">stirabos@redhat.com</a>></span> = wrote:<br class=3D""><blockquote class=3D"gmail_quote" style=3D"margin:0px= 0px 0px 0.8ex;border-left:1px solid = rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr" class=3D""><br = class=3D""><div class=3D"gmail_extra"><br class=3D""><div = class=3D"gmail_quote"><span class=3D"">On Wed, Oct 5, 2016 at 10:34 AM, = Nir Soffer <span dir=3D"ltr" class=3D""><<a = href=3D"mailto:nsoffer@redhat.com" target=3D"_blank" = class=3D"">nsoffer@redhat.com</a>></span> wrote:<br = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px = 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div = dir=3D"ltr" class=3D""><div class=3D"gmail_extra"><div = class=3D"gmail_quote"><span class=3D"">On Wed, Oct 5, 2016 at 10:24 AM, = Simone Tiraboschi <span dir=3D"ltr" class=3D""><<a = href=3D"mailto:stirabos@redhat.com" target=3D"_blank" = class=3D"">stirabos@redhat.com</a>></span> wrote:<br = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px = 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div = dir=3D"ltr" class=3D""><br class=3D""><div class=3D"gmail_extra"><br = class=3D""><div class=3D"gmail_quote"><span class=3D"">On Wed, Oct 5, = 2016 at 9:17 AM, gregor <span dir=3D"ltr" class=3D""><<a = href=3D"mailto:gregor_forum@catrix.at" target=3D"_blank" = class=3D"">gregor_forum@catrix.at</a>></span> wrote:<br = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px = 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br = class=3D""> <br class=3D""> did you found a solution or cause for this high CPU usage?<br class=3D""> I have installed the self hosted engine on another server and there = is<br class=3D""> no VM running but ovirt-ha-agent uses heavily the CPU.<br = class=3D""></blockquote><div class=3D""><br class=3D""></div></span>Yes, = it's due to the fact that ovirt-ha-agent periodically reconnects over = json rpc and this is CPU intensive since the client has to parse the = yaml API specification each time it connects.<br = class=3D""></div></div></div></blockquote></span></div></div></div></block= quote></span></div></div></div></blockquote></div></div></div></div></bloc= kquote><div class=3D""><br class=3D""></div></span>wasn=E2=80=99t it = suppose to be fixed to reuse the connection? Like all the other clients = (vdsm migration code:-) </div></div></blockquote><div class=3D""><br = class=3D""></div><div class=3D"">This is orthogonal = issue.</div></div></div></div></div></blockquote><div class=3D""><br = class=3D""></div></span>Yes it is. And that=E2=80=99s the = issue;-)</div><div class=3D"">Both are wrong, but by =E2=80=9Cfixing=E2=80= =9D the schema validation only you lose the motivation to fix the = meaningless wasteful reconnect</div></div></blockquote><div class=3D""><br= class=3D""></div><div class=3D"">Yes, we are going to fix that too ( <a = href=3D"https://bugzilla.redhat.com/show_bug.cgi?id=3D1349829" = class=3D"">https://bugzilla.redhat.com/show_bug.cgi?id=3D1349829</a> = ) </div></div></div></div></div></blockquote><div><br = class=3D""></div>that=E2=80=99s great! Also al the other vdsClient = uses?:-)</div><div>What is that periodic one call anyway? Is there only = one? Maybe we don=E2=80=99t need it so much.</div><div><br = class=3D""><blockquote type=3D"cite" class=3D""><div class=3D""><div = dir=3D"ltr" class=3D""><div class=3D"gmail_extra"><div = class=3D"gmail_quote"><div class=3D"">but it would require also <a = href=3D"https://bugzilla.redhat.com/show_bug.cgi?id=3D1376843" = class=3D"">https://bugzilla.redhat.com/show_bug.cgi?id=3D1376843</a> = to be fixed.</div></div></div></div></div></blockquote><div><br = class=3D""></div>This is less good. Well, worst case you can reconnect = yourself, all you need is a notification when the existing connection = breaks</div><div><br class=3D""><blockquote type=3D"cite" class=3D""><div = class=3D""><div dir=3D"ltr" class=3D""><div class=3D"gmail_extra"><div = class=3D"gmail_quote"><div class=3D""> </div><blockquote = class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px = solid rgb(204,204,204);padding-left:1ex"><div = style=3D"word-wrap:break-word" class=3D""><div class=3D""><span = class=3D"gmail-"><br class=3D""><blockquote type=3D"cite" class=3D""><div = class=3D""><div dir=3D"ltr" class=3D""><div class=3D"gmail_extra"><div = class=3D"gmail_quote"><div class=3D""> </div><blockquote = class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px = solid rgb(204,204,204);padding-left:1ex"><div = style=3D"word-wrap:break-word" class=3D""><div class=3D"">Does schema = validation matter then if there would be only one connection at the = start up?</div></div></blockquote><div class=3D""><br = class=3D""></div><div class=3D"">Loading once does not help command line = tools like vdsClient, hosted-engine and</div><div = class=3D"">vdsm-tool. </div></div></div></div></div></blockquote><div= class=3D""><br class=3D""></div></span>none of the other tools is using = json-rpc.</div></div></blockquote><div class=3D""><br = class=3D""></div><div class=3D"">hosted-engine-setup is, and sooner or = later we'll have to migrate also the remaining tools since xmlrpc has = been deprecated with = 4.0</div></div></div></div></div></blockquote><div><br = class=3D""></div>ok. though setup is a one-time action so it=E2=80=99s = not an issue there</div><div><br class=3D""><blockquote type=3D"cite" = class=3D""><div class=3D""><div dir=3D"ltr" class=3D""><div = class=3D"gmail_extra"><div class=3D"gmail_quote"><div = class=3D""> </div><blockquote class=3D"gmail_quote" = style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid = rgb(204,204,204);padding-left:1ex"><div style=3D"word-wrap:break-word" = class=3D""><span class=3D"gmail-"><div class=3D""><br = class=3D""><blockquote type=3D"cite" class=3D""><div class=3D""><div = dir=3D"ltr" class=3D""><div class=3D"gmail_extra"><div = class=3D"gmail_quote"><div class=3D""><br class=3D""></div><div = class=3D"">Nir</div><div class=3D""> </div><blockquote = class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px = solid rgb(204,204,204);padding-left:1ex"><div = style=3D"word-wrap:break-word" class=3D""><div class=3D""><br = class=3D""><blockquote type=3D"cite" class=3D""><div class=3D""><span = class=3D""><div dir=3D"ltr" class=3D""><div class=3D"gmail_extra"><div = class=3D"gmail_quote"><blockquote class=3D"gmail_quote" = style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid = rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr" class=3D""><div = class=3D"gmail_extra"><div class=3D"gmail_quote"><span = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px = 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div = dir=3D"ltr" class=3D""><div class=3D"gmail_extra"><div = class=3D"gmail_quote"><span class=3D""><div class=3D""><br = class=3D""></div></span><div class=3D"">Simone, reusing the connection = is good idea anyway, but what you describe is </div><div class=3D"">a= bug in the client library. The library does *not* need to load and = parse the</div><div class=3D"">schema at all for sending requests to = vdsm.</div><div class=3D""><br class=3D""></div><div class=3D"">The = schema is only needed if you want to verify request = parameters,</div><div class=3D"">or provide online help, these are not = needed in a client library.</div><div class=3D""><br class=3D""></div><div= class=3D"">Please file an infra bug about = it.</div></div></div></div></blockquote><div class=3D""><br = class=3D""></div></span><div class=3D"">Done, <a = href=3D"https://bugzilla.redhat.com/show_bug.cgi?id=3D1381899" = target=3D"_blank" class=3D"">https://bugzilla.redhat.com/sh<wbr = class=3D"">ow_bug.cgi?id=3D1381899</a></div></div></div></div></blockquote= that should eliminate most most of the problem:</div><div class=3D""><a = href=3D"https://gerrit.ovirt.org/65230" target=3D"_blank" = class=3D"">https://gerrit.ovirt.org/65230</a><br class=3D""></div><div = class=3D""><br class=3D""></div><div class=3D"">Would be nice if it can = be tested on the system showing this problem.</div><div class=3D""><br = class=3D""></div><div class=3D"">Cheers,</div><div = class=3D"">Nir</div></div></div></div></span><span class=3D""> ______________________________<wbr class=3D"">_________________<br = class=3D"">Users mailing list<br class=3D""><a = href=3D"mailto:Users@ovirt.org" target=3D"_blank" = class=3D"">Users@ovirt.org</a><br class=3D""><a = href=3D"http://lists.ovirt.org/mailman/listinfo/users" target=3D"_blank" = class=3D"">http://lists.ovirt.org/mailman<wbr = class=3D"">/listinfo/users</a><br = class=3D""></span></div></blockquote></div><br = class=3D""></div></blockquote></div><br class=3D""></div></div> ______________________________<wbr class=3D"">_________________<br = class=3D"">Users mailing list<br class=3D""><a = href=3D"mailto:Users@ovirt.org" target=3D"_blank" = class=3D"">Users@ovirt.org</a><br class=3D""><a = href=3D"http://lists.ovirt.org/mailman/listinfo/users" target=3D"_blank" = class=3D"">http://lists.ovirt.org/<wbr = class=3D"">mailman/listinfo/users</a><br = class=3D""></div></blockquote></div><br class=3D""></span></div><br = class=3D"">______________________________<wbr = class=3D"">_________________<br class=3D""> Users mailing list<br class=3D""> <a href=3D"mailto:Users@ovirt.org" class=3D"">Users@ovirt.org</a><br = class=3D""> <a href=3D"http://lists.ovirt.org/mailman/listinfo/users" = rel=3D"noreferrer" target=3D"_blank" = class=3D"">http://lists.ovirt.org/<wbr = class=3D"">mailman/listinfo/users</a><br class=3D""> <br class=3D""></blockquote></div><br class=3D""></div></div> _______________________________________________<br class=3D"">Users = mailing list<br class=3D""><a href=3D"mailto:Users@ovirt.org" = class=3D"">Users@ovirt.org</a><br = class=3D"">http://lists.ovirt.org/mailman/listinfo/users<br = class=3D""></div></blockquote></div><br class=3D""></body></html>= --Apple-Mail=_B5E3106A-94F6-40B0-A9A6-4DD310F17BA3--