code sign-off/DCO for ovirt projects

[Ryan Harper]

* Itamar Heim <iheim at redhat.com> [2012-04-10 03:57]:
> top posting to make sure this is visible:
> touched based with danken and enabled this for vdsm project.
> if there are any issues/more time needed for adjustment, will disable 
> and re-enable.
> 
> http://gerrit.googlecode.com/svn/documentation/2.0/user-signedoffby.html#Signed-off-by

Excellent!  When would we enable this for the remaining ovirt-* projects?
(engine, cli, sdk, etc.)?


> 
> 
> On 04/08/2012 11:11 AM, Dan Kenigsberg wrote:
> >On Sat, Apr 07, 2012 at 01:00:27AM +0300, Itamar Heim wrote:
> >>On 04/06/2012 06:00 PM, Ryan Harper wrote:
> >>>Re-sending this to arch as in our meeting this week we agreed[1] no 
> >>>reason
> >>>to not implement DCO (http://kerneltrap.org/files/Jeremy/DCO.txt) but
> >>>that we needed to enlist the maintainers to work out enforcement.
> >>
> >>that's easy enough since we use gerrit.
> >>if acked by all, i can simply enable 'force sign-off' on patches
> >>option in gerrit and it will be enforced...
> >>
> >>>
> >>>
> >>>1. http://lists.ovirt.org/pipermail/arch/2012-April/000433.html
> >
> >
> >I do not mind requring the make-my-lawyer-happy line in all Vdsm commits,
> >and I suppose that this would be fine by everybody on vdsm-devel. Tell
> >us when this takes effect, we'll prepare our commit-msg hooks by then.
> >
> >Anything cooler we can do beyond putting
> >
> >SOB=$(git var GIT_AUTHOR_IDENT | sed -n 's/^\(.*>\).*$/Signed-off-by: 
> >\1/p')
> >grep -qs "^$SOB" "$1" || echo "$SOB">>  "$1"
> >
> >at the bottom of .git/hooks/commit-msg ?
> >
> >>>
> >>>----- Forwarded message from Ryan Harper<ryanh at us.ibm.com>   -----
> >>>
> >>>From: Ryan Harper<ryanh at us.ibm.com>
> >>>Subject: code sign-off/DCO for ovirt projects
> >>>Date: Tue, 3 Apr 2012 14:59:40 -0500
> >>>Message-ID:<20120403195940.GB5061 at us.ibm.com>
> >>>User-Agent: Mutt/1.5.6+20040907i
> >>>To: board at ovirt.org
> >>>
> >>>I see that this was discussed in the past on the board list[1] and there
> >>>didn't seem to be any disagreement with doing DCO sign-off for code
> >>>contributions.  However, not all of the ovirt projects are doing
> >>>DCO/Sign-off.  There are a few commits in vdms.git that have a SoB,
> >>>ovirt-node seems to be using DCO completely.  Nothing in ovirt-engine
> >>>either.  I didn't check all of the ovirt subprojects, but I think
> >>>it's safe to assume that's not being applied across all of the
> >>>projects consistently.
> >>>
> >>>Can we get that added to the commit process for these projects moving
> >>>forward? Is there anything else needed beyond maintainers enforcing the
> >>>need for SoB in patches?
> >>>
> >>>
> >>>1. http://lists.ovirt.org/pipermail/board/2011-October/000168.html
> >>>
> >>
> >>_______________________________________________
> >>Arch mailing list
> >>Arch at ovirt.org
> >>http://lists.ovirt.org/mailman/listinfo/arch

-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh at us.ibm.com