What the new gerrit hoks will do

[David Caro]

On Tue 30 Jul 2013 09:11:22 PM CEST, Itamar Heim wrote:
> On 07/30/2013 10:02 PM, David Caro wrote:
>> Hi all!
>>
>> As promised here's an explanation of what the hooks will take care of:
>>
>> When a patch is submitted:
>>    If the commit message has Bug-Url tag:
>>      - for each Bug-Url:
>>        * Check that the bug is public
>>        * Add an external tracker to the patch if not there already
>>        * Move the bug status to POST
>>      - Report back the result of all the previous actions
>>      - Review with +1 if the bug was public, -1 if it was private
>
> shouldn't +1, only -1.

You are right! It only reviews the patch and clears it's previous 
review (set's it as neutral, not +1).

>
>>
>> When a comment is added:
>>    If the "Rerun-Hooks: all" line was added:
>>      - Rerun all the hooks that ran when the hook was submitted
>>
>> When a patch is submitted:
>>    If the commit message has Bug-Url:
>>      - For each Bug-Url:
>>        * Check if the product for the bug is correct
>
> meaning it checks the bug is on the ovirt bugzilla?

Correct, it checks that the bug belongs to the oVirt product.

>
>>        * If it was, move the bug status to MODIFIED
>>
>> Keep in mind that this is a first step towards automation of the whole
>> process.
>>
>> Also, as always any input, ideas, or even complaints are welcome :)
>>
>> pd. Yes I will add this and more info to the wiki as soon as I have some
>> spare time to do it.
>>
>>
>>
>> _______________________________________________
>> Arch mailing list
>> Arch at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/arch
>>
>



--
David Caro

Red Hat Czech s.r.o.
Continuous Integration Engineer - EMEA ENG Virtualization R&D

Tel.: +420 532 294 605
Email: dcaro at redhat.com
Web: www.cz.redhat.com
Red Hat Czech s.r.o., Purkyňova 99/71, 612 45, Brno, Czech Republic
RHT Global #: 82-62605