What the new gerrit hoks will do

[David Caro]

On 07/31/2013 10:35 AM, Maor Lipchuk wrote:
> Would not having the dependency of gerrit with bugzilla might cause us
> latency issues when pushing patches while bugzilla server will encounter
> network issues or will be unavailable?

No, as the hooks are execute post-action. They are also executed in
another thread so the user does not experience any change in gerrit's
behavior, any action that you do on gerrit will take the same amount of
time it did before, .

It can become a problem if there are lots of slow hooks and lots of
commits, but that will only slow down the machine, and right now we have
a huge margin of operation in that aspect.

> 
> Regards,
> Maor
> 
> On 07/31/2013 11:01 AM, David Caro wrote:
>> On 07/31/2013 09:24 AM, Itamar Heim wrote:
>>> On 07/31/2013 10:23 AM, Alon Bar-Lev wrote:
>>>>
>>>> Hi,
>>>>
>>>> I don't think it is good to have auto POST/MODIFIED.
>>>> As there can be more than one patch per bug.
>>>
>>> i think post is still correct.
>>> modified will only move if all patches with this bug-url are merged iiuc.
>>> a new patch with same bug-url will move the bug back to POST.
>>
>> Right, I forgot to clarify that only those bugs with all their external
>> tracked patches closed will be changed to MODIFIED.
>>
>>>
>>>>
>>>> Alon
>>>>
>>>> ----- Original Message -----
>>>>> From: "David Caro" <dcaroest at redhat.com>
>>>>> To: arch at ovirt.org
>>>>> Sent: Tuesday, July 30, 2013 10:02:46 PM
>>>>> Subject: What the new gerrit hoks will do
>>>>>
>>>>> Hi all!
>>>>>
>>>>> As promised here's an explanation of what the hooks will take care of:
>>>>>
>>>>> When a patch is submitted:
>>>>>    If the commit message has Bug-Url tag:
>>>>>      - for each Bug-Url:
>>>>>        * Check that the bug is public
>>>>>        * Add an external tracker to the patch if not there already
>>>>>        * Move the bug status to POST
>>>>>      - Report back the result of all the previous actions
>>>>>      - Review with +1 if the bug was public, -1 if it was private
>>>>>
>>>>> When a comment is added:
>>>>>    If the "Rerun-Hooks: all" line was added:
>>>>>      - Rerun all the hooks that ran when the hook was submitted
>>>>>
>>>>> When a patch is submitted:
>>>>>    If the commit message has Bug-Url:
>>>>>      - For each Bug-Url:
>>>>>        * Check if the product for the bug is correct
>>>>>        * If it was, move the bug status to MODIFIED
>>>>>
>>>>> Keep in mind that this is a first step towards automation of the whole
>>>>> process.
>>>>>
>>>>> Also, as always any input, ideas, or even complaints are welcome :)
>>>>>
>>>>> pd. Yes I will add this and more info to the wiki as soon as I have some
>>>>> spare time to do it.
>>>>>
>>>>> -- 
>>>>> David Caro
>>>>>
>>>>> Red Hat Czech s.r.o.
>>>>> Continuous Integration Engineer - EMEA ENG Virtualization R&D
>>>>>
>>>>> Tel.: +420 532 294 605
>>>>> Email: dcaro at redhat.com
>>>>> Web: www.cz.redhat.com
>>>>> Red Hat Czech s.r.o., Purkyňova 99/71, 612 45, Brno, Czech Republic
>>>>> RHT Global #: 82-62605
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Arch mailing list
>>>>> Arch at ovirt.org
>>>>> http://lists.ovirt.org/mailman/listinfo/arch
>>>>>
>>>> _______________________________________________
>>>> Arch mailing list
>>>> Arch at ovirt.org
>>>> http://lists.ovirt.org/mailman/listinfo/arch
>>>>
>>>
>>
>>
>>
>>
>> _______________________________________________
>> Arch mailing list
>> Arch at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/arch
>>
> 


-- 
David Caro

Red Hat Czech s.r.o.
Continuous Integration Engineer - EMEA ENG Virtualization R&D

Tel.: +420 532 294 605
Email: dcaro at redhat.com
Web: www.cz.redhat.com
Red Hat Czech s.r.o., Purkyňova 99/71, 612 45, Brno, Czech Republic
RHT Global #: 82-62605

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: OpenPGP digital signature
URL: <http://lists.ovirt.org/pipermail/arch/attachments/20130731/213c3483/attachment.sig>