ovirt-engine build failure

Tue Feb 18 17:33:50 UTC 2014

----- Original Message -----
> From: "Sandro Bonazzola" <sbonazzo at redhat.com>
> To: "Vojtech Szocs" <vszocs at redhat.com>, "Eyal Edri" <eedri at redhat.com>
> Cc: "Juan Hernandez" <jhernand at redhat.com>, "Kiril Nesenko" <knesenko at redhat.com>, "arch" <arch at ovirt.org>
> Sent: Tuesday, February 18, 2014 2:00:58 PM
> Subject: Re: ovirt-engine build failure
> 
> Il 18/02/2014 13:32, Vojtech Szocs ha scritto:
> > 
> > 
> > ----- Original Message -----
> >> From: "Eyal Edri" <eedri at redhat.com>
> >> To: "Alon Bar-Lev" <alonbl at redhat.com>
> >> Cc: "Juan Hernandez" <jhernand at redhat.com>, "arch" <arch at ovirt.org>,
> >> "Kiril Nesenko" <knesenko at redhat.com>
> >> Sent: Tuesday, February 18, 2014 10:46:58 AM
> >> Subject: Re: ovirt-engine build failure
> >>
> >>
> >>
> >> ----- Original Message -----
> >>> From: "Alon Bar-Lev" <alonbl at redhat.com>
> >>> To: "Sandro Bonazzola" <sbonazzo at redhat.com>
> >>> Cc: "Juan Hernandez" <jhernand at redhat.com>, "Kiril Nesenko"
> >>> <knesenko at redhat.com>, "Eyal Edri" <eedri at redhat.com>,
> >>> "David Caro" <dcaroest at redhat.com>, "arch" <arch at ovirt.org>
> >>> Sent: Tuesday, February 18, 2014 11:37:41 AM
> >>> Subject: Re: ovirt-engine build failure
> >>>
> >>>
> >>>
> >>> ----- Original Message -----
> >>>> From: "Sandro Bonazzola" <sbonazzo at redhat.com>
> >>>> To: "Alon Bar-Lev" <alonbl at redhat.com>
> >>>> Cc: "Juan Hernandez" <jhernand at redhat.com>, "Kiril Nesenko"
> >>>> <knesenko at redhat.com>, "Eyal Edri" <eedri at redhat.com>,
> >>>> "David Caro" <dcaroest at redhat.com>, "arch" <arch at ovirt.org>
> >>>> Sent: Tuesday, February 18, 2014 11:36:29 AM
> >>>> Subject: Re: ovirt-engine build failure
> >>>>
> >>>> Il 18/02/2014 09:49, Alon Bar-Lev ha scritto:
> >>>>>
> >>>>>
> >>>>> ----- Original Message -----
> >>>>>> From: "Sandro Bonazzola" <sbonazzo at redhat.com>
> >>>>>> To: "Juan Hernandez" <jhernand at redhat.com>, "Alon Bar-Lev"
> >>>>>> <alonbl at redhat.com>
> >>>>>> Cc: "Kiril Nesenko" <knesenko at redhat.com>, "Eyal Edri"
> >>>>>> <eedri at redhat.com>,
> >>>>>> "David Caro" <dcaroest at redhat.com>, "arch"
> >>>>>> <arch at ovirt.org>
> >>>>>> Sent: Tuesday, February 18, 2014 10:13:54 AM
> >>>>>> Subject: ovirt-engine build failure
> >>>>>>
> >>>>>> Hi, we hit again an issue that comes up really often while building
> >>>>>> ovirt-engine in jenkins,
> >>>>>> especially when we're in a hurry because we're releasing.
> >>>>>>
> >>>>>> http://jenkins.ovirt.org/job/manual-build-tarball/212/label=fedora19-host/console
> >>>>>>
> >>>>>> IIRC it may be a corrupted artifact or an error in maven dependency
> >>>>>> resolution.
> >>>>>> Can we find a way for having it fixed once for ever?
> >>>>>
> >>>>> We are using a local artifactory mirror, so having corruption is
> >>>>> unlikely.
> >>>>> I think that maven checks sha1 of artifacts and reports corruption
> >>>>> issue
> >>>>> before trying to use.
> >>>>> In this case something is failing at gwt generation, I am unsure if it
> >>>>> is
> >>>>> not related to resources.
> >>>>
> >>>> The weird thing is that it may fail on the same point for a tenth of
> >>>> times
> >>>> and then build successfully on the exact same host.
> >>>> And that's the only job running on a 4 core i7 processor with 16 GB of
> >>>> ram.
> >>>
> >>> With or without cleaning up the workspace?
> >>
> >> it also failed on a baremetal host locally. http://pastebin.com/07wANdVG
> > 
> > To me it seems like error during GWT compilation, i.e. invocation of
> > gwt-maven-plugin's compile goal that performs GWT compilation.
> > 
> > Failed to execute goal org.codehaus.mojo:gwt-maven-plugin:2.5.1:compile
> > (gwtcompile) on project webadmin: Command [[
> > ...
> > ]] failed with status 1
> > 
> > Can we re-run this build with mvn -X flag to see debug-level Maven logs?
> > 
> > Looking at [1] I have some questions/comments:
> > 
> > * I don't see any "-Dgwt.userAgent=..." override, shouldn't Makefile ensure
> > this is set properly?
> >   Without this, oVirt GUI is compiled for *all* browsers supported by GWT
> >   SDK, which increases compilation time & memory usage.
> >   Note that oVirt GUI should be compiled *only* for following browsers [2]:
> >   ie8,ie9,gecko1_8,safari,opera
> 
> Can you open a bz about it, make it blocker for 3.4.0 and possibly push a
> patch?

Hm, first I'd like to consult this with Alon, in Makefile we have:

  DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS=-Dgwt.userAgent=gecko1_8

which means "compile GWT UI for Firefox (only) by default". This
is effective only for development builds.

For non-development builds, I don't think we set "gwt.userAgent"
property at all.

What we should do (I think) is something like this:

  # By default, non-development builds will have
  # GWT UI compiled for all supported browsers:
  #     IE8, IE9, Firefox (Gecko), Safari/Chrome, Opera
  BUILD_GWT_USERAGENT=ie8,ie9,gecko1_8,safari,opera

  # Apply change to BUILD_FLAGS
  BUILD_FLAGS:=$(BUILD_FLAGS) -D gwt.userAgent=$(BUILD_GWT_USERAGENT)

Note that BUILD_GWT_USERAGENT excludes "ie6" (IE6-7) permutation,
as we don't support IE6-7.

Alon, does ^^ make sense to you?

Quick workaround:

  EXTRA_BUILD_FLAGS='-Dgwt.userAgent=ie8,ie9,gecko1_8,safari,opera'

(above option should be passed to "make" command)

> 
> > 
> > * maybe set "-Dgwt.compiler.localWorkers=..." to #_of_logical_CPUs
> > available on that host
> >   Higher value means faster compilation but can increase memory usage
> >   (until we move away from JVM-based worker processes)
> 
> We set it to 1 due to excessive memory usage. Without that, we run out of
> memory.

I see, please discard my suggestion regarding localWorkers for now.

> 
> 
> > 
> > [1]
> > http://jenkins.ovirt.org/job/manual-build-tarball/212/label=fedora19-host/consoleFull
> > [2] frontend/webadmin/modules/pom.xml -> gwt.userAgent property -> lists
> > all supported browsers
> > 
> > Vojtech
> > 
> >>  
> >>
> >>>
> >>>>
> >>>>
> >>>>>
> >>>>>>
> >>>>>>
> >>>>>> --
> >>>>>> Sandro Bonazzola
> >>>>>> Better technology. Faster innovation. Powered by community
> >>>>>> collaboration.
> >>>>>> See how it works at redhat.com
> >>>>>>
> >>>>
> >>>>
> >>>> --
> >>>> Sandro Bonazzola
> >>>> Better technology. Faster innovation. Powered by community
> >>>> collaboration.
> >>>> See how it works at redhat.com
> >>>>
> >>>
> >> _______________________________________________
> >> Arch mailing list
> >> Arch at ovirt.org
> >> http://lists.ovirt.org/mailman/listinfo/arch
> >>
> > _______________________________________________
> > Arch mailing list
> > Arch at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/arch
> > 
> 
> 
> --
> Sandro Bonazzola
> Better technology. Faster innovation. Powered by community collaboration.
> See how it works at redhat.com
> 