[urgent] Re: ovirt-engine build failure

[Vojtech Szocs]

----- Original Message -----
> From: "Alon Bar-Lev" <alonbl at redhat.com>
> To: "Vojtech Szocs" <vszocs at redhat.com>
> Cc: "Sandro Bonazzola" <sbonazzo at redhat.com>, "Juan Hernandez" <jhernand at redhat.com>, "Kiril Nesenko"
> <knesenko at redhat.com>, "arch" <arch at ovirt.org>
> Sent: Wednesday, February 26, 2014 12:48:07 PM
> Subject: Re: [urgent] Re: ovirt-engine build failure
> 
> 
> 
> ----- Original Message -----
> > From: "Vojtech Szocs" <vszocs at redhat.com>
> > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > Cc: "Sandro Bonazzola" <sbonazzo at redhat.com>, "Juan Hernandez"
> > <jhernand at redhat.com>, "Kiril Nesenko"
> > <knesenko at redhat.com>, "arch" <arch at ovirt.org>
> > Sent: Wednesday, February 26, 2014 1:25:50 PM
> > Subject: Re: [urgent] Re: ovirt-engine build failure
> > 
> > 
> > > > No, it's not that big of a deal *for our packaging* but since we've
> > > > people
> > > > on
> > > > Gentoo building engine
> > > > on their own systems, it may impact all of them...
> > > 
> > > We can have clear note that limits should be modified to support locale
> > > build.
> > 
> > +1
> > 
> > Maybe this (or similar): "When building Engine for multiple/all locales,
> > please check max open files limit to avoid errors during GWT compilation."
> > 
> > > 
> > > We can run limit -n at Makefile and fail.
> > 
> > I'm not sure we can get good-enough/accurate "n" value since this depends
> > on
> > many different factors (including number of small images used in GWT
> > application), so I'd just vote for clear note as suggested above.
> > 
> 
> Surely we can check for at least 10K, which should be sufficient.

OK, I'm not against it :)

> 
> Nobody will understand the above comment, people need specific action.
> 
> Something like:
> 
> "Current open file limit is set to NNN while XXX is required, please see
> README.developer for instructions"

+1

I meant my comment as note inside README.developer (but I didn't mention it),
to make it clear that max open files limit is required by GWT compiler and
higher value is required when building lots of (i.e. multiple langs) permutations.

> 
> Alon
>