[Engine-devel] Please review: All In One Feature page

[Itamar Heim]

On 04/01/2012 12:09 PM, Alex Lourie wrote:
> Hi All
>
> I've written a new wiki page [1] for a feature we've developed, called All in One. This allows configuring VDSM on the same host with rhevm (ovirt) automatically during setup.
>

1. "Plugin will wait to allow JBoss to start correctly. This is done 
because other steps involve using REST API (with ovirtsdk), which 
requires JBoss to be up. "

how are you planning to perform this check?

2. "Plugin will create a local host and add it to host list."
worth mentioning bootstrapping code was changed to allow to not reboot a 
host for this.

3. "The plugin works by providing parameters, group and sequences and 
adding them into the Controller object (the main object of the setup 
flow), which will invoke appropriate logic during the setup operation. "

nice - I like it is modular code.