[ovirt-devel] [ENGINE] thoughts about LinqUtils

[Yevgeny Zaspitsky]

On 21/08/14 12:08, Yair Zaslavsky wrote:
>
> ----- Original Message -----
>> From: "Yevgeny Zaspitsky" <yzaspits at redhat.com>
>> To: "Moti Asayag" <masayag at redhat.com>
>> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, "Allon Mureinik" <amureini at redhat.com>, devel at ovirt.org
>> Sent: Thursday, August 21, 2014 11:26:40 AM
>> Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils
>>
>> It seems like we can try moving to common-collections4. Yum on my Fedora20
>> computer finds apache-commons-collections4 package. Fortunately somebody
>> packed the jar into for a rpm for us. :-)
> What about RHEL 6.5? Can you please run a quick check?
Unfortunately my happiness was too hasty. Only Fedora people care to be 
in the forward of the technology... The RHEL ones do not care about that...
>>
>> ----- Original Message -----
>>> From: "Moti Asayag" <masayag at redhat.com>
>>> To: "Yair Zaslavsky" <yzaslavs at redhat.com>
>>> Cc: "Allon Mureinik" <amureini at redhat.com>, devel at ovirt.org, "Yevgeny
>>> Zaspitsky" <yzaspits at redhat.com>
>>> Sent: Thursday, August 21, 2014 11:18:53 AM
>>> Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils
>>>
>>>
>>>
>>> ----- Original Message -----
>>>> From: "Yair Zaslavsky" <yzaslavs at redhat.com>
>>>> To: "Allon Mureinik" <amureini at redhat.com>
>>>> Cc: "Moti Asayag" <masayag at redhat.com>, devel at ovirt.org, "Yevgeny
>>>> Zaspitsky" <yzaspits at redhat.com>
>>>> Sent: Thursday, August 21, 2014 11:04:13 AM
>>>> Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils
>>>>
>>>>
>>>>
>>>> ----- Original Message -----
>>>>> From: "Allon Mureinik" <amureini at redhat.com>
>>>>> To: "Moti Asayag" <masayag at redhat.com>
>>>>> Cc: "Yair Zaslavsky" <yzaslavs at redhat.com>, devel at ovirt.org
>>>>> Sent: Thursday, August 21, 2014 10:53:01 AM
>>>>> Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils
>>>>>
>>>>> IMO, we have too many classes that do the same (useless) thing -
>>>>> org.ovirt.engine.core.utils.linq.LinqUtils and
>>>>> org.ovirt.engine.core.common.utils.ListUtils, which both have no place
>>>>> in
>>>>> oVirt-engine.
>>>>> Why not scrap both of them, upgrade commons-collections to the modern
>>>>> 4.0
>>>>> and
>>>>> use org.apache.commons.collections4.CollectionUtils which has all of
>>>>> their
>>>>> functionality, fully-tested, and maintained by someone else?
>>>> Regarding upgrade to 4.0 - IMHO there was some packaging issue.
>>>> I think Yevgeny Zaspitsky raised the issue at the past.
>>>>
>>> This is the mentioned thread:
>>> http://lists.ovirt.org/pipermail/devel/2014-April/007050.html
>>>
>>>> But yeah, if there is no issue there, I'm in favor.
>>>>
>>>>
>>>>> ----- Original Message -----
>>>>>> From: "Moti Asayag" <masayag at redhat.com>
>>>>>> To: "Yair Zaslavsky" <yzaslavs at redhat.com>
>>>>>> Cc: devel at ovirt.org
>>>>>> Sent: Thursday, August 21, 2014 9:04:05 AM
>>>>>> Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils
>>>>>>
>>>>>>
>>>>>>
>>>>>> ----- Original Message -----
>>>>>>> From: "Yair Zaslavsky" <yzaslavs at redhat.com>
>>>>>>> To: devel at ovirt.org
>>>>>>> Sent: Thursday, August 21, 2014 5:50:44 AM
>>>>>>> Subject: [ovirt-devel] [ENGINE] thoughts about LinqUtils
>>>>>>>
>>>>>>> Hi Engine developers (and others :) ),
>>>>>>> I would like to share some thoughts & questions with you about the
>>>>>>> future
>>>>>>> of
>>>>>>> LinqUtils
>>>>>>>
>>>>>>> 1. Location of LinqUtils
>>>>>>>
>>>>>>> Currently LinqUtils resides at utils.
>>>>>>> However, as LinqUtils contains some non engine related code, I
>>>>>>> think
>>>>>>> it
>>>>>>> should be moved to the new uutils (universal utils) project.
>>>>>>> uutils was introduced during the work on AAA, in order to provide a
>>>>>>> set
>>>>>>> of
>>>>>>> utilities that are not engine related, and hopefully in the future
>>>>>>> will
>>>>>>> be
>>>>>>> published as a separate artifcat on
>>>>>>> maven central (Alon, feel free to correct me here :) )
>>>>>>>
>>>>>> +1
>>>>>> You'd probably have to address the entire
>>>>>> org.ovirt.engine.core.utils.linq
>>>>>> package
>>>>>> and not just that specific class.
>>>>>> A sort of a clean-up is also required (i.e. remove IDE generated
>>>>>> comments),
>>>>>> seems
>>>>>> like a good chance to do it.
>>>>>>
>>>>>>> 2. The name LinqUtils - Linq comes from c#. I think these days are
>>>>>>> way
>>>>>>> behind
>>>>>>> us (3 years or so now?) i would like to suggest renaming the class.
>>>>>>> CollectionUtils? Any other suggestions are more than welcome
>>>>>>>
>>>>>> +1
>>>>>>
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Yair
>>>>>>> _______________________________________________
>>>>>>> Devel mailing list
>>>>>>> Devel at ovirt.org
>>>>>>> http://lists.ovirt.org/mailman/listinfo/devel
>>>>>>>
>>>>>> _______________________________________________
>>>>>> Devel mailing list
>>>>>> Devel at ovirt.org
>>>>>> http://lists.ovirt.org/mailman/listinfo/devel
>>>>>>