[ovirt-devel] Creating a new gerrit flag

Francesco Romani fromani at redhat.com
Tue Dec 9 09:48:00 UTC 2014

----- Original Message -----
> From: "David Caro" <dcaroest at redhat.com>
> To: devel at ovirt.org, infra at ovirt.org
> Sent: Tuesday, December 9, 2014 10:43:04 AM
> Subject: [ovirt-devel] Creating a new gerrit flag
> Hi!
> e have been having an issue with gerrit patches being merged before
> jenkins ran any tests on them, to avoid it from happening again I
> propose creating a new gerrit flag (Tests) with the following
> specifics:
> +1 - Tests passed/overrided
>  0 - Tests pending
> -1 - Tests broken
> where +1 is required to submit, +1 is set by jenkins when
> passing the tests and -1 is set by jenkins in case it breaks any
> tests. The +1 flag can be set also by maintainers to allow overriding
> the process.
> That way all the tests will be blocked until someone (hopefully
> jenkins) adds the +1 flag, but if the maintainer wants to override the
> value, she just has to set that flag herself.
> What do you think?

Looks good, but there is a scenario which worries me a bit.

It happened in the past times that an otherwise good and working patch
failed the tests because, for example, pep8 or pyflakes became stricter
about the code formatting.

Can the maintainer override such a -1 from failed tests in that case?
(probably yes, but worth asking)


Francesco Romani
RedHat Engineering Virtualization R & D
Phone: 8261328
IRC: fromani

More information about the Devel mailing list