[ovirt-devel] vdsm-jsonrpc-java failing builds on el6

[Alon Bar-Lev]

----- Original Message -----
> From: "Piotr Kliczewski" <pkliczew at redhat.com>
> To: "Alon Bar-Lev" <alonbl at redhat.com>
> Cc: "Sandro Bonazzola" <sbonazzo at redhat.com>, "Saggi Mizrahi" <smizrahi at redhat.com>, devel at ovirt.org
> Sent: Friday, July 18, 2014 8:01:39 PM
> Subject: Re: [ovirt-devel] vdsm-jsonrpc-java failing builds on el6
> 
> 
> 
> 
> 
> ----- Original Message -----
> > From: "Alon Bar-Lev" <alonbl at redhat.com>
> > To: "Sandro Bonazzola" <sbonazzo at redhat.com>, "Piotr Kliczewski"
> > <pkliczew at redhat.com>
> > Cc: "Saggi Mizrahi" <smizrahi at redhat.com>, devel at ovirt.org
> > Sent: Friday, July 18, 2014 6:19:05 PM
> > Subject: Re: [ovirt-devel] vdsm-jsonrpc-java failing builds on el6
> > 
> > 
> > 
> > ----- Original Message -----
> > > From: "Sandro Bonazzola" <sbonazzo at redhat.com>
> > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > Cc: "Piotr Kliczewski" <pkliczew at redhat.com>, "Saggi Mizrahi"
> > > <smizrahi at redhat.com>, devel at ovirt.org
> > > Sent: Friday, July 18, 2014 7:11:43 PM
> > > Subject: Re: [ovirt-devel] vdsm-jsonrpc-java failing builds on el6
> > > 
> > > Il 18/07/2014 17:59, Alon Bar-Lev ha scritto:
> > > > 
> > > > 
> > > > ----- Original Message -----
> > > >> From: "Sandro Bonazzola" <sbonazzo at redhat.com>
> > > >> To: "Piotr Kliczewski" <pkliczew at redhat.com>, "Saggi Mizrahi"
> > > >> <smizrahi at redhat.com>, devel at ovirt.org
> > > >> Sent: Friday, July 18, 2014 6:34:32 PM
> > > >> Subject: [ovirt-devel] vdsm-jsonrpc-java failing builds on el6
> > > >>
> > > >> Hi,
> > > >> we'll have 3.5 beta 2 on Monday and vdsm-jsonrpc-java is still failing
> > > >> to
> > > >> build on CentOS 6[1].
> > > >> Can you please fix it?
> > > > 
> > > > you are not building this using rpmbuild, please avoid building
> > > > manually.
> > > 
> > > Not sure about what you mean. However,
> > > 
> > > # cat /etc/system-release
> > > CentOS release 6.5 (Final)
> > > 
> > > # git clone git://gerrit.ovirt.org/vdsm-jsonrpc-java
> > > # cd vdsm-jsonrpc-java/
> > > # ./autogen.sh
> > > # ./configure
> > > # make dist
> > > # rpmbuild -ta vdsm-jsonrpc-java-1.0.0_master.tar.gz
> > > error: Failed build dependencies:
> > > 	codehaus-jackson-core-asl is needed by
> > > 	vdsm-jsonrpc-java-1.0.0-0.0.master.el6.noarch
> > > 	codehaus-jackson-mapper-asl is needed by
> > > 	vdsm-jsonrpc-java-1.0.0-0.0.master.el6.noarch
> > > 
> > > 
> > > Looking at http://gerrit.ovirt.org/28974
> > > above deps shouldn't be there.
> > > 
> > > spec changelog say:
> > > * Tue Jun 24 2014 Piotr Kliczewski <pkliczew at redhat.com> 1.0.1
> > > - Make jackson dependency conditional for rhel and centos
> > > 
> > > but tarball generated is still 1.0.0.
> > 
> > yes, there is problem with maintainers to understand the release management
> > within master, I already explain that one many times.
> > 1. tag name should be PACKAGE-VERSION
> > 2. post release must increment version and have pre-release rpm release
> > 
> > > so also rpmbuild fails.
> > 
> > yes, this error is right.
> > 
> > piotr the following should also be conditioned:
> > 
> > BuildRequires:»       codehaus-jackson-core-asl
> > BuildRequires:»       codehaus-jackson-mapper-asl
> >
> 
> I though that we agreed to use maven to build for centos and fedora. For rhel
> we agreed
> to use brew. In this situation when maven is used the build time dependencies
> are not
> checked. Am I missing something?

if you specify something in spec, it is checked...
we use maven so we download these during build (violation of spec) because there is no package.
this means we cannot specify these as dependencies in spec.

> 
> > 
> > > jenkins uses mock after building src.rpm from tar.gz and mock just
> > > provide
> > > build requirements and then rpmbuild the src.rpm
> > 
> > you cannot build using mock this package for centos, dcaro already aware of
> > this, because of missing build time dependencies which are available at
> > runtime, so instead of package these, we just use maven to download them.
> > 
> > Thanks!
> > 
>