[ovirt-devel] VDSM sync meeting minutes June 24th, 2014

[Michal Skrivanek]

On Jun 25, 2014, at 17:00 , Dan Kenigsberg <danken at redhat.com> wrote:

> On Wed, Jun 25, 2014 at 07:46:52AM -0400, Antoni Segura Puimedon wrote:
>> 
>> 
>> ----- Original Message -----
>>> From: "Francesco Romani" <fromani at redhat.com>
>>> To: "Dan Kenigsberg" <danken at redhat.com>, "Saggi Mizrahi" <smizrahi at redhat.com>
>>> Cc: devel at ovirt.org
>>> Sent: Wednesday, June 25, 2014 1:15:03 PM
>>> Subject: Re: [ovirt-devel] VDSM sync meeting minutes June 24th, 2014
>>> 
>>> 
>>> ----- Original Message -----
>>>> From: "Francesco Romani" <fromani at redhat.com>
>>>> To: "Dan Kenigsberg" <danken at redhat.com>, "Saggi Mizrahi"
>>>> <smizrahi at redhat.com>
>>>> Cc: devel at ovirt.org
>>>> Sent: Wednesday, June 25, 2014 10:06:37 AM
>>>> Subject: Re: [ovirt-devel] VDSM sync meeting minutes June 24th, 2014
>>>> 
>>>> ----- Original Message -----
>>>>> From: "Dan Kenigsberg" <danken at redhat.com>
>>>>> To: devel at ovirt.org
>>>>> Sent: Tuesday, June 24, 2014 4:13:05 PM
>>>>> Subject: [ovirt-devel] VDSM sync meeting minutes June 24th, 2014
>>>> 
>>>> [...]
>>>>> - Francesco posted a new threadpool implementation. It's implemented
>>>>>  with statistics threads in mind, but should be used by storage/tasks,
>>>>>  too. As such infra and storage folks should review it.
>>>> 
>>>> The code is on my github. The history may be messed, but the concepts
>>>> are in there and it is reviewable:
>>>> 
>>>> https://github.com/mojaves/vdsm/tree/master/lib/threadpool
>>>> 
>>>> it is used only here:
>>>> 
>>>> https://github.com/mojaves/vdsm/blob/master/vdsm/virt/sampling.py
>>>> 
>>>> I'm now adding at least the initial test and polishing the code.
>>>> I'll post a proper patch on gerrit hopefully within the end of the week,
>>>> in order to ease the review.
>>>> 
>>> 
>>> Initial draft posted in the hope to ease the review:
>>> http://gerrit.ovirt.org/#/c/29189/
>>> http://gerrit.ovirt.org/#/c/29190/
>>> http://gerrit.ovirt.org/#/c/29191/
>>> 
>>> These patches will be kept in-sync with changes I make on github: testing and
>>> docs,
>>> mostly, and adjustement of the code to make testing easier. The core concepts
>>> are there.
>>> 
>>> This is the core part - the new pool implementation; the port of the virt
>>> sampling code
>>> and the other pieces will follow soon in separate patches.
>>> 
>>> A very valid point was raised by Nir in #vdsm:
>>> if we choose to go ahead with this new thread pool, should this code put in a
>>> separate project like cpopen or ioprocess?
>> 
>> I vote for separate oVirt gerrit project.
> 
> Do we expect anyone outside Vdsm to make use of it soon?
> 
> If so, go ahead!
> 
> If not, this would excert release-engineering costs, with no clear
> benefits. Someone would have to tag a build, and push it to
> Fedora/debian.

+1
I'd be concerned with the added overhead. We can always do that once there is another potential users...

> 
> cpopen and ioprocess are written in C and as such are less
> fitting to be inside Vdsm.
> _______________________________________________
> Devel mailing list
> Devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel