[ovirt-devel] [vdsm] pep8 issue

[Dan Kenigsberg]

On Tue, May 13, 2014 at 05:22:15PM -0300, Amador Pahim wrote:
> Building vdsm/master in F20, I've got:
> 
> ./vdsm/virt/migration.py:223:19: E225 missing whitespace around operator
> 
> In vdsm/virt/migration.py:
> 
> 218         e.err = (libvirt.VIR_ERR_OPERATION_ABORTED,  # error code$
> 219                  libvirt.VIR_FROM_QEMU,              # error
> domain$
> 220                  'operation aborted',                # error
> message$
> 221                  libvirt.VIR_ERR_WARNING,            # error
> level$
> 222                  '', '', '',                         # str1, str2,
> str3,$
> 223                  -1, -1)                             # int1, int2$
> 224         raise e$
> 
> pep8 is not accepting negative integer. Instead, it is handling the
> minus sign as an operator. Quick workaround is change -1 to int(-1).
> Is this a known?

Now it is ;-)

>
> I'm using python-pep8-1.5.4-1.fc20.noarch

It seems like a bug in pep8 tool, and I see that it does not reproduce
with v1.5.6 thereof.

I'm adding Matthias who may agree to backport the fix to Fedora 20 (or
upgrade completely to 1.5.6)