[ovirt-devel] vdsm make rpm & make check on fe vs el

[Francesco Romani]

> ----- Original Message -----
> > From: "Mooli Tayer" <mtayer at redhat.com>
> > To: devel at ovirt.org
> > Sent: Monday, October 27, 2014 11:16:41 AM
> > Subject: [ovirt-devel] vdsm make rpm & make check on fe vs el
> > 
> > Isn't this odd?
> > 
> > Fedora release 20 (Heisenbug)
> > =============================
> > $ make check 2>&1 | grep -E "^Ran"
> > Ran 2 tests in 1.006s
> > Ran 1 test in 0.070s
> > Ran 691 tests in 63.504s
> > $ make rpm 2>&1 | grep -E "^Ran" | tail -f
> > Ran 2 tests in 1.005s
> > Ran 1 test in 0.069s
> > Ran 691 tests in 63.937s
> > $
> > 
> > 
> > 
> > Red Hat Enterprise Linux Server release 6.6 (Santiago)
> > ======================================================
> > 
> > $  make check 2>&1 | grep -E "^Ran"
> > Ran 2 tests in 1.003s
> > Ran 1 test in 0.082s
> > Ran 691 tests in 61.114s
> > $  make rpm 2>&1 | grep -E "^Ran"
> > $
> > 
> > I've also saw a different numbers of tests running for make rpm on el.
> 
> I have seen this on several 6.5 machines - make rpm on does *not* run
> the tests.
> 
> It would be nice if take a look at this.

It was made on purposes:

# Skips check since rhel default repos lack pep8 and pyflakes
%if ! 0%{?rhel}
%global with_check 1
%endif

http://gerrit.ovirt.org/#/c/29213/

I believe time has come for a more robust solution


-- 
Francesco Romani
RedHat Engineering Virtualization R & D
Phone: 8261328
IRC: fromani