[ovirt-devel] Failing patch because of wrong documentation generation

Sagi Shnaidman sshnaidm at redhat.com
Mon Apr 6 13:31:36 UTC 2015


hi all

we have a failing jenkins job because of problematic patch:
https://gerrit.ovirt.org/#/c/39186/

1) First of all there were no added package dependencies, that caused to
job to fail on all platforms:
http://jenkins.ovirt.org/job/ovirt-engine-sdk_master_create-rpms_merged/212/

but this could be solved by my patch: https://gerrit.ovirt.org/#/c/39569/

2) Secondly, the python-sphinx module on el6 has a very early version
with different command name for document generation and this causes to
fail on el6:
http://jenkins.ovirt.org/job/ovirt-engine-sdk_master_create-rpms_merged/217/

So the patch should be reverted and rewritten and tested before it's
merged on all platforms.

Also you can see that nobody has reviewed this patch and this is a main
root cause to such problems. This is always better to have the patch to
be reviewed by anybody, otherwise it makes all Gerrit process completely
useless and pushes problems forward instead of locating them on early
stages.
--
Thanks



More information about the Devel mailing list