[ovirt-devel] [ACTION REQUIRED] ovirt-engine build failing on master

[Alexander Wels]

On Tuesday, December 15, 2015 03:11:41 PM Einav Cohen wrote:
> > (a) such patch cannot be merged because a unit-test, *even if ran during
> > compilation for English only*, should fail (see [1]).
> 
> update: after discussing with Alexander: the unit-test doesn't
> cover the UIMessages file - that's why it was not detectable
> when compiling in English only.
> 
> @Alexander - can you please extend the unit-test to include UIMessages?
> 
> [1] https://gerrit.ovirt.org/#/c/32995/
> 

Patch that includes UIMessages is posted here [2]

[2] https://gerrit.ovirt.org/#/c/50556

> ----- Original Message -----
> 
> > From: "Einav Cohen" <ecohen at redhat.com>
> > To: "Tal Nisan" <tnisan at redhat.com>, "Alexander Wels" <awels at redhat.com>,
> > "Tomas Jelinek" <tjelinek at redhat.com> Cc: "devel" <devel at ovirt.org>
> > Sent: Tuesday, December 15, 2015 7:30:40 AM
> > Subject: Re: [ovirt-devel] [ACTION REQUIRED] ovirt-engine build failing on
> > master> 
> > > ----- Original Message -----
> > > From: "Tal Nisan" <tnisan at redhat.com>
> > > Sent: Tuesday, December 15, 2015 5:29:17 AM
> > > 
> > > Einav, it seems like an old issue we had when the default message
> > > contains
> > > the necessary placeholders but since no translations patch was released
> > > yet
> > > we don't have the placeholders in the translated messages, did we decide
> > > on
> > > a workaround back then?
> > 
> > (a) such patch cannot be merged because a unit-test, *even if ran during
> > compilation for English only*, should fail (see [1]).
> > 
> > @Alexander - can you please take a look at it with Tomas and see what
> > happened (original patch merged without running unit-tests / problem
> > with the unit-test itself [1] / ...)?
> > 
> > (b) non-English .properties files should typically not be modified as part
> > of regular patches (i.e. patches that are not dedicated "translation
> > updates" which include updates to the files pulled directly from Zanata).
> > 
> > *However*, there is one exception for that, and the exception is
> > compilation error that happens due to the reason that you mentioned above
> > - changes in English message variable-placeholders.
> > In this case - the patch author must change the matching messages in the
> > non- English .properties files to include the exact same
> > variable-placeholders as the (updated) English message (i.e. remove
> > placeholders / add placeholders as necessary).
> > 
> > [1]
> > http://lists.ovirt.org/pipermail/engine-commits/2014-October/018907.html> 
> > > On Tue, Dec 15, 2015 at 12:04 PM, Sandro Bonazzola <sbonazzo at redhat.com>
> > > 
> > > wrote:
> > > > *05:22:42* [INFO]                   [ERROR] Required argument 3 not
> > > > present: {0} ({1} Sockets, {2} Kerne pro Socket)*05:22:42* [INFO]
> > > > [ERROR] Errors in
> > > > 'org/ovirt/engine/ui/uicompat/ConstantsManager.java'*05:22:42* [INFO]
> > > > [ERROR] Line 38: Failed to resolve
> > > > 'org.ovirt.engine.ui.uicompat.UIMessages' via deferred binding
> > > > 
> > > > 
> > > > See
> > > > http://jenkins.ovirt.org/job/ovirt-engine_master_build-artifacts-el7-x
> > > > 86_64/682/console
> > > > 
> > > > 
> > > > Please fix ASAP
> > > > 
> > > > 
> > > > 
> > > > --
> > > > Sandro Bonazzola
> > > > Better technology. Faster innovation. Powered by community
> > > > collaboration.
> > > > See how it works at redhat.com
> > > > 
> > > > _______________________________________________
> > > > Devel mailing list
> > > > Devel at ovirt.org
> > > > http://lists.ovirt.org/mailman/listinfo/devel
> > 
> > _______________________________________________
> > Devel mailing list
> > Devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel