[ovirt-devel] [Spice-devel] spice proxy support in govirt

Christophe Fergeau cfergeau at redhat.com
Thu Jan 22 15:57:06 UTC 2015


On Thu, Jan 15, 2015 at 02:04:37PM +0100, Christophe Fergeau wrote:
> I quickly cooked/compile-tested the attached patch, if you have time to
> test it, let me know how it works, otherwise I'll get back to that later
> (need to get lot of email under control first ;)
> 
> Christophe

> diff --git a/govirt/ovirt-vm-display.c b/govirt/ovirt-vm-display.c
> index a8a0942..0a8adc6 100644
> --- a/govirt/ovirt-vm-display.c
> +++ b/govirt/ovirt-vm-display.c
> @@ -141,6 +146,9 @@ static void ovirt_vm_display_set_property(GObject *object,
>      case PROP_ALLOW_OVERRIDE:
>          display->priv->allow_override = g_value_get_boolean(value);
>          break;
> +    case PROP_PROXY_URL:
> +        g_free(display->priv->proxy_url);
> +        display->priv->proxy_url = g_value_dup_string(value);

Missing break; here

Apart from this, this is working fine, I've pushed it upstream:
https://git.gnome.org/browse/libgovirt/commit/?id=e2f4e6ae0975b24d4d4cb521ff1a2948e91af0e3

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20150122/95f12aa7/attachment.sig>


More information about the Devel mailing list