[ovirt-devel] useless warnings in engine.log

[Vojtech Szocs]

----- Original Message -----
> From: "Alexander Wels" <awels at redhat.com>
> To: "Omer Frenkel" <ofrenkel at redhat.com>
> Cc: devel at ovirt.org
> Sent: Friday, July 17, 2015 5:41:53 PM
> Subject: Re: [ovirt-devel] useless warnings in engine.log
> 
> On Wednesday, July 15, 2015 11:44:51 AM Omer Frenkel wrote:
> > ----- Original Message -----
> > 
> > > From: "Alexander Wels" <awels at redhat.com>
> > > To: devel at ovirt.org
> > > Cc: "Omer Frenkel" <ofrenkel at redhat.com>
> > > Sent: Wednesday, July 15, 2015 4:09:02 PM
> > > Subject: Re: [ovirt-devel] useless warnings in engine.log
> > > 
> > > On Wednesday, July 15, 2015 08:23:20 AM Omer Frenkel wrote:
> > > > Hi,
> > > > lately i noticed my engine.log filled with useless warnings, every 30
> > > > secs:
> > > > 2015-07-15 15:03:38,961 WARN
> > > > [org.ovirt.engine.core.branding.BrandingFilter] (default task-38) []
> > > > Detected Locale is null, setting to default 'en_US' 2015-07-15
> > > > 15:04:08,964
> > > > WARN  [org.ovirt.engine.core.branding.BrandingFilter] (default task-41)
> > > > []
> > > > Detected Locale is null, setting to default 'en_US'
> > > 
> > > Basically that warning is created by the BrandingFilter, in response to a
> > > missing locale attribute in the request object. The LocaleFilter should
> > > have the object in there. Instead of blowing up, it defaults to English
> > > and writes the warning. So this does indicate there is something wrong
> > > with your setup. Can you determine which URL is being called that is
> > > causing the problem?
> > > 
> > > If not change line 62 in the BrandingFilter from:
> > > log.warn("Detected Locale is null, setting to default '{}'",
> > > LocaleFilter.DEFAULT_LOCALE);
> > > 
> > > to
> > > 
> > > log.warn("Detected Locale is null, setting to default '{}'",
> > > LocaleFilter.DEFAULT_LOCALE,
> > > ((HttpServletRequest)request).getRequestURL());
> > url is 'http://localhost:8080/ovirt-engine/404.html'
> >
> 
> [1] should fix the issue
> 
> The LocaleFilter was not defined for the services path. The patch add the
> filter
> to the appropriate web.xml
> 
> [1] https://gerrit.ovirt.org/#/c/43782/1

+1 from me, web fragments anyone? :)

>  
> > > This will require you to import HttpServletRequest, but your IDE should
> > > be
> > > able to do that for you.
> > > 
> > > In short, this should never happen as the LocaleFilter should run before
> > > BrandingFilter, and it is guaranteed to populate the locale attribute.
> > > 
> > > > anything changed? anything wrong with my setup that i need to set in
> > > > order
> > > > to solve this? also, i think that recurring msgs like this should go to
> > > > debug...
> > > > 
> > > > Thanks,
> > > > Omer.
> > > > _______________________________________________
> > > > Devel mailing list
> > > > Devel at ovirt.org
> > > > http://lists.ovirt.org/mailman/listinfo/devel
> 
> _______________________________________________
> Devel mailing list
> Devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>