[ovirt-devel] Stomp regression in vdsm master

[Adam Litke]

On 12/06/15 15:36 +0200, Piotr Kliczewski wrote:
>On Fri, Jun 12, 2015 at 3:23 PM, Adam Litke <alitke at redhat.com> wrote:
>> On 12/06/15 15:13 +0200, Piotr Kliczewski wrote:
>>>
>>> On Fri, Jun 12, 2015 at 3:11 PM, Adam Litke <alitke at redhat.com> wrote:
>>>>
>>>> On 12/06/15 11:46 +0200, Piotr Kliczewski wrote:
>>>>>
>>>>>
>>>>> On Fri, Jun 12, 2015 at 11:28 AM, Michal Skrivanek
>>>>> <michal.skrivanek at redhat.com> wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>> On 12 Jun 2015, at 02:38, Adam Litke wrote:
>>>>>>
>>>>>>> On 09/06/15 08:41 +0200, Piotr Kliczewski wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>> Adam,
>>>>>>>>
>>>>>>>> Thank you for reporting.
>>>>>>>>
>>>>>>>> There is work in parallel on the engine side so please refresh your
>>>>>>>> engine as well.
>>>>>>>> The changes that you listed should work with engine 3.5 but will fail
>>>>>>>> as you described
>>>>>>>> for older master.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> I upgraded engine to latest master (72368f3) and vdsm as well
>>>>>>> (718909e) and connections were still completely broken between my
>>>>>>> engine and vdsm until I reverted https://gerrit.ovirt.org/#/c/38451/ .
>>>>>>> I think there is something real here.
>>>>>>
>>>>>>
>>>>>>
>>>>>> I got similar reports from Omer as of yesterday ~noon, both sides
>>>>>> latest
>>>>>>
>>>>>
>>>>> Is vdsm-jsonrpc-java latest?
>>>>
>>>>
>>>>
>>>> I have the following in my local maven repo:
>>>>
>>>> $ find  ~/.m2 -name \*jsonrpc\*.jar
>>>>
>>>> /home/alitke/.m2/repository/org/ovirt/vdsm-jsonrpc-java/vdsm-jsonrpc-java-client/1.1.1-SNAPSHOT/vdsm-jsonrpc-java-client-1.1.1-SNAPSHOT.jar
>>>>
>>>> /home/alitke/.m2/repository/org/ovirt/vdsm-jsonrpc-java/vdsm-jsonrpc-java-client/1.1.1-SNAPSHOT/vdsm-jsonrpc-java-client-1.1.1-20150420.133832-3.jar
>>>
>>>
>>> above is the latest merged. Can you share your logs?
>>
>>
>> Attached.
>>
>
>Looking at the logs I do not see any issues but I do not see any
>processed messages on vdsm side.
>
>Please apply this patch [1] it should solve this issue.

Indeed it does.  Thanks!

>
>[1] https://gerrit.ovirt.org/#/c/38819
>
>>
>>
>>>
>>>>
>>>> /home/alitke/.m2/repository/org/ovirt/vdsm-jsonrpc-java/vdsm-jsonrpc-java-client/1.0.15/vdsm-jsonrpc-java-client-1.0.15.jar
>>>>
>>>> /home/alitke/.m2/repository/org/ovirt/vdsm-jsonrpc-java/vdsm-jsonrpc-java-client/1.1.0-SNAPSHOT/vdsm-jsonrpc-java-client-1.1.0-SNAPSHOT.jar
>>>>
>>>> /home/alitke/.m2/repository/org/ovirt/vdsm-jsonrpc-java/vdsm-jsonrpc-java-client/1.1.0-SNAPSHOT/vdsm-jsonrpc-java-client-1.1.0-20150407.125052-6.jar
>>>>
>>>>
>>>>
>>>>
>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Piotr
>>>>>>>>
>>>>>>>>
>>>>>>>> On Mon, Jun 8, 2015 at 10:54 PM, Adam Litke <alitke at redhat.com>
>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Hi Piotr,
>>>>>>>>>
>>>>>>>>> Today I refreshed my vdsm master branch and got the 4 commits at the
>>>>>>>>> bottom of this email (among others).  My engine started having
>>>>>>>>> connection timeouts to vdsm (100% connectivity failure).  Reverting
>>>>>>>>> the commits resolved the problem for me.  I don't have logs at the
>>>>>>>>> moment but just wanted to share this info in case anyone else
>>>>>>>>> started
>>>>>>>>> experiencing connectivity problems to vdsm.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> 14897fea06e8f21ae99144ee0294b21e08ea0892 stomp: calling super
>>>>>>>>> explicitly
>>>>>>>>> ed12db391f2f147443baf52b5519d51ad5bd3410 stomp: allow single stomp
>>>>>>>>> reactor
>>>>>>>>> ac85274145cd82eec804e3585b3cd12a6c13261a stompreactor: fix naming of
>>>>>>>>> default
>>>>>>>>> destination
>>>>>>>>> c80ab0657d4f0454c3141aadeadcf134e5f16de7 stomp: server side
>>>>>>>>> subscriptions
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Adam Litke
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Adam Litke
>>>>>>> _______________________________________________
>>>>>>> Devel mailing list
>>>>>>> Devel at ovirt.org
>>>>>>> http://lists.ovirt.org/mailman/listinfo/devel
>>>>>>
>>>>>>
>>>>>>
>>>>
>>>> --
>>>> Adam Litke
>>
>>
>> --
>> Adam Litke

-- 
Adam Litke