[ovirt-devel] master broken

[Oved Ourfali]

Seems like there is part of the add host flow that calls "update" before the entity is actually saved.
Logically, that's wrong, but we've posted a fix for that to cover this flow, just to make sure there are no other regressions.
In addition, we'll fix this logic anyway.

Patch will be merged soon (pending another verification).

Thanks!
Oved

----- Original Message -----
> From: "Oved Ourfali" <ovedo at redhat.com>
> To: "Piotr Kliczewski" <piotr.kliczewski at gmail.com>
> Cc: devel at ovirt.org
> Sent: Tuesday, June 16, 2015 11:14:56 AM
> Subject: Re: [ovirt-devel] master broken
> 
> We're looking into it.
> 
> Oved
> 
> ----- Original Message -----
> > From: "Piotr Kliczewski" <piotr.kliczewski at gmail.com>
> > To: devel at ovirt.org
> > Sent: Tuesday, June 16, 2015 11:07:16 AM
> > Subject: [ovirt-devel]  master broken
> > 
> > Guys,
> > 
> > I attempted to add a host using latest master code and got following
> > exception:
> > 
> > 2015-06-16 10:01:28,854 WARN
> > [org.ovirt.engine.core.bll.hostdeploy.AddVdsCommand]
> > (http--0_0_0_0_0_0_0_0-8080-3) [14cc5839] CanDoAction of action
> > 'AddVds' failed for user admin at internal. Reasons:
> > VAR__ACTION__ADD,VAR__TYPE__HOST,$server
> > 192.168.1.7,VDS_SECURITY_CONNECTION_ERROR,$ErrorMessage Couldn't store
> > fingerprint to db for host 192.168.1.7:
> > javax.persistence.PersistenceException:
> > org.hibernate.id.IdentifierGenerationException: ids for this class
> > must be manually assigned before calling save():
> > org.ovirt.engine.core.common.businessentities.VdsStatic,VDS_CANNOT_AUTHENTICATE_TO_SERVER
> > 2015-06-16 10:01:41,724 ERROR
> > [org.ovirt.engine.core.utils.transaction.TransactionalInterceptor]
> > (http--0_0_0_0_0_0_0_0-8080-3) [740e96b9] Failed to run operation in a
> > new transaction: javax.persistence.PersistenceException:
> > org.hibernate.id.IdentifierGenerationException: ids for this class
> > must be manually assigned before calling save():
> > org.ovirt.engine.core.common.businessentities.VdsStatic
> > at
> > org.hibernate.ejb.AbstractEntityManagerImpl.convert(AbstractEntityManagerImpl.java:1361)
> > [hibernate-entitymanager-4.0.1.Final.jar:4.0.1.Final]
> > at
> > org.hibernate.ejb.AbstractEntityManagerImpl.convert(AbstractEntityManagerImpl.java:1289)
> > [hibernate-entitymanager-4.0.1.Final.jar:4.0.1.Final]
> > at
> > org.hibernate.ejb.AbstractEntityManagerImpl.convert(AbstractEntityManagerImpl.java:1295)
> > [hibernate-entitymanager-4.0.1.Final.jar:4.0.1.Final]
> > at
> > org.hibernate.ejb.AbstractEntityManagerImpl.merge(AbstractEntityManagerImpl.java:876)
> > [hibernate-entitymanager-4.0.1.Final.jar:4.0.1.Final]
> > at
> > org.jboss.as.jpa.container.AbstractEntityManager.merge(AbstractEntityManager.java:548)
> > [jboss-as-jpa-7.1.1.Final.jar:7.1.1.Final]
> > at
> > org.ovirt.engine.core.dao.jpa.AbstractJpaDao.update(AbstractJpaDao.java:60)
> > [dal.jar:]
> > at
> > org.ovirt.engine.core.dao.VdsStaticDAODbFacadeImpl$Proxy$_$$_WeldSubclass.update(VdsStaticDAODbFacadeImpl$Proxy$_$$_WeldSubclass.java)
> > 
> > Thanks,
> > Piotr
> > _______________________________________________
> > Devel mailing list
> > Devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
> > 
> > 
> > 
> _______________________________________________
> Devel mailing list
> Devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>