[ovirt-devel] [vdsm] strange network test failure on FC23

[Francesco Romani]

Hi,

Jenkins doesn't like my (trivial) https://gerrit.ovirt.org/#/c/49271/

which is about moving one log line (!).

The failure is

00:08:54.680 ======================================================================
00:08:54.680 FAIL: testEnablePromisc (ipwrapperTests.TestDrvinfo)
00:08:54.680 ----------------------------------------------------------------------
00:08:54.680 Traceback (most recent call last):
00:08:54.680   File "/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/ipwrapperTests.py", line 130, in testEnablePromisc
00:08:54.680     "Could not enable promiscuous mode.")
00:08:54.680 AssertionError: Could not enable promiscuous mode.
00:08:54.680 -------------------- >> begin captured logging << --------------------
00:08:54.680 root: DEBUG: /usr/bin/taskset --cpu-list 0-1 /usr/sbin/brctl show (cwd None)
00:08:54.680 root: DEBUG: SUCCESS: <err> = ''; <rc> = 0
00:08:54.680 root: DEBUG: /usr/bin/taskset --cpu-list 0-1 /sbin/ip link add name vdsm-HIRjJp type bridge (cwd None)
00:08:54.680 root: DEBUG: SUCCESS: <err> = ''; <rc> = 0
00:08:54.680 root: DEBUG: /usr/bin/taskset --cpu-list 0-1 /sbin/ip link set dev vdsm-HIRjJp up (cwd None)
00:08:54.680 root: DEBUG: SUCCESS: <err> = ''; <rc> = 0
00:08:54.680 root: DEBUG: /usr/bin/taskset --cpu-list 0-1 /sbin/ip link set dev vdsm-HIRjJp promisc on (cwd None)
00:08:54.680 root: DEBUG: SUCCESS: <err> = ''; <rc> = 0
00:08:54.680 --------------------- >> end captured logging << ---------------------


Here in fullest: http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc23-x86_64/638/console

The command like looks OK, and can't think any reason it could fail, except startup race.
Using taskset, the ip command now takes a little longer to complete.

Maybe -just wild guessing- the code isn't properly waiting for the command to complete?
Otherwise not the slightest clue :)

Bests,

-- 
Francesco Romani
RedHat Engineering Virtualization R & D
Phone: 8261328
IRC: fromani