[ovirt-devel] [vdsm] Running VDSM unit tests on Travis CI using Docker

[Nir Soffer]

On Wed, Apr 6, 2016 at 1:41 PM, Milan Zamazal <mzamazal at redhat.com> wrote:
> Edward Haas <ehaas at redhat.com> writes:
>
>> On Wed, Apr 6, 2016 at 11:39 AM, Milan Zamazal <mzamazal at redhat.com> wrote:
>>
>>     Thank you, Edward, this is useful not only for CI. I use docker for
>>     building Vdsm and running its unit tests and this helped me to get the
>>     proper updated set of packages after recent changes in Vdsm.
>>
>>     BTW, it seems that the following packages should be additionally added
>>     for `make check-all': psmisc, which, python-ioprocess
>>
>>
>> Are you saying that make check is passing on your local machine?
>
> When I add the packages given above, `make check-all' (as well as `make
> check') works for me except for 4 tests in lib/vdsm/schedule.py that
> produce the following errors with `make check-all':

Thanks!

Can you send a patch to add the missing packages to our travis config?

>
>     File "/home/pdm/ovirt/vdsm/vdsm-test/lib/vdsm/schedule.py", line 134, in schedule
>       heapq.heappush(self._calls, (deadline, call))
>   nose.proxy.TypeError: unorderable types: ScheduledCall() < ScheduledCall()
>
>     File "/home/pdm/ovirt/vdsm/vdsm-test/tests/scheduleTests.py", line 160, in test_latency
>       med = ticker.latency[len(ticker.latency) / 2]
>   nose.proxy.TypeError: list indices must be integers, not float
>
> Those are probably Python 3 failures that should be fixed in Vdsm.
> The docker environment works fine for running the unit tests on my
> machine.

Correct, the code is not compatible with python 3, we must implement
rich comparison to make it work on Python 3 (__lt__, __le__, etc.)

> _______________________________________________
> Devel mailing list
> Devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel