[ovirt-devel] findbugs on network code

[Martin Mucha]

I think that's probable explanation. Another NPE can be (theoretically) here 
org.ovirt.engine.core.utils.customprop.DevicePropertiesUtils#getDeviceProperties
when reading using null version (static analysis can probably find way into this method), but cancel is more imminent.

M.

----- Original Message -----
> 
> > On Jan 15, 2016, at 9:21 AM, Michal Skrivanek <michal.skrivanek at redhat.com>
> > wrote:
> > 
> > somehow findbugs started to fail[1] on network code
> > any idea why?
> 
> To me this looks like that might be because of the VnicProfileModel base
> class which accesses the sourceModel parameter without checking if it is
> null or not in the cancel method.
> 
> But that is just a hunch
> 
> > 
> > Thanks,
> > michal
> > 
> > [1]
> > http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/43304/findbugsResult/new/
> > _______________________________________________
> > Devel mailing list
> > Devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
> 
>