[ovirt-devel] [vdsm] Another network test failing

[Adam Litke]

On 17/05/16 09:45 +0300, Dan Kenigsberg wrote:
>On Tue, May 17, 2016 at 01:10:19AM +0300, Nir Soffer wrote:
>> On Mon, May 16, 2016 at 4:52 PM, Adam Litke <alitke at redhat.com> wrote:
>> > On 15/05/16 15:10 +0300, Dan Kenigsberg wrote:
>> >>
>> >> On Sun, May 15, 2016 at 10:33:30AM +0300, Edward Haas wrote:
>> >>>
>> >>> On Tue, May 10, 2016 at 8:19 PM, Adam Litke <alitke at redhat.com> wrote:
>> >>>
>> >>> > On 10/05/16 18:08 +0300, Dan Kenigsberg wrote:
>> >>> >
>> >>> >> On Mon, May 09, 2016 at 02:48:43PM -0400, Adam Litke wrote:
>> >>> >>
>> >>> >>> When running make check on my local system I often (but not always)
>> >>> >>> get the following error:
>> >>> >>>
>> >>> >>
>> >>> >> Do you have any clue related to when this happens? (your pwd,
>> >>> >> pythonpath)
>> >>> >>
>> >>> >
>> >>> > Maybe it's a side effect of the way nose loads and runs tests?
>> >>> >
>> >>> > Did it begin with the recent move of netinfo under vdsm.network?
>> >>> >> https://gerrit.ovirt.org/56713 (CommitDate: Thu May 5) or did you see
>> >>> >> it
>> >>> >> earlier?
>> >>> >>
>> >>> >
>> >>> > That's possible.  It only started happening recently.  It seems to
>> >>> > fail only when run under 'make check' but not when run via
>> >>> > ./run_tests_local.sh.
>> >>>
>> >>>
>> >>> Is it possible that on the same machine you have installed an older vdsm
>> >>> version
>> >>> and it somehow conflicts? (resolving vdsm from the site-packages instead
>> >>> from
>> >>> the local workspace)
>> >>
>> >>
>> >> Or maybe you have *.pyc from an older directory structure left in your
>> >> working directory?
>> >
>> >
>> > I think this was the issue.  Removing *.pyc from the source tree fixed
>> > it.  Thanks!
>>
>> git clean -dxf is very useful from time to time
>
>Yet very dangerous in another times (yes, once upon a time I had the
>only copy of a helper script hiding within the leafs of a git tree)


Been there too.  Maybe it's time we fix 'make clean'.

-- 
Adam Litke