[ovirt-devel] [ ERROR ] schema.sh: Please fix numbering to interval 04010491 to 04010500 and run the upgrade script.

[Eyal Edri]

What does it mean to clean the jobs?  You mean git history or temp files?

On Nov 24, 2016 1:23 AM, "Martin Perina" <mperina at redhat.com> wrote:

> So, I tested current master and also upgrade from 4.0 to master and
> everything works fine on my local machine.
>
> But I've found 2 issues:
>
> 1. Jenkins CI for some reason unknown to me doesn't use current master
> (change-id: I59087ff8902e35b9f7c922eba0a17ba4f0791795) but it uses older
> commit (most probably revert patch from Eyal [1] with Change-Id:
> I8c2350aba48619dfa84624b343cfa167d0b6e0ed).as a current master when
> executing upgrade job from master to patch
>
> 2. When we are reverting patches which contain db upgrade scripts which
> are not last (for example we are dropping db script 04_01_0500 when there's
> already merged script 04_01_0510) we cannot delete upgrade script otherwise
> db schema upgrade script fails (revert script [1] is faulty). Only
> following actions are valid in this case:
>
>   a. Comment out code in db upgrade script we want to revert, but leave
> this script in the repo
>
>   b. Remove the db upgrade script and renumber all later db upgrade
> scripts so there's no hole in db upgrade script numbering
>
> Conclusion: current code in master is OK, we need clean up jenkins job to
> really use latest merged patch on git master branch.
>
> Martin
>
>
> [1] https://gerrit.ovirt.org/#/c/67205/
>
>
> On Wed, Nov 23, 2016 at 7:17 PM, Michal Skrivanek <mskrivan at redhat.com>
> wrote:
>
>>
>>
>> > On 23 Nov 2016, at 17:44, Martin Sivak <msivak at redhat.com> wrote:
>> >
>> > Yeah, our patches are still failing as well. It seems the patch was
>> > not enough or there is some other conflicting db script.
>>
>> I think the hash changed. IIRC there was some issue in the logic when the
>> existing script is updated (since it was merged and reverted and re-merged
>> with the same number, but it was not the exact same content)
>> Martin/Eli to the rescue!
>>
>> >
>> > Martin
>> >
>> >> On Wed, Nov 23, 2016 at 2:16 PM, Sandro Bonazzola <sbonazzo at redhat.com>
>> wrote:
>> >>
>> >>
>> >>> On Wed, Nov 23, 2016 at 2:13 PM, Arik Hadas <ahadas at redhat.com>
>> wrote:
>> >>>
>> >>> it should be fixed now (by https://gerrit.ovirt.org/#/c/67210/)
>> >>
>> >>
>> >> I rebased https://gerrit.ovirt.org/66999 and still failing there.
>> >>
>> >>
>> >>>
>> >>> ----- Original Message -----
>> >>>> engine master CI is failing on $subject, please fix or revert as
>> soon as
>> >>>> possible, thanks.
>> >>>>
>> >>>> --
>> >>>> Sandro Bonazzola
>> >>>> Better technology. Faster innovation. Powered by community
>> >>>> collaboration.
>> >>>> See how it works at redhat.com
>> >>>>
>> >>>> _______________________________________________
>> >>>> Devel mailing list
>> >>>> Devel at ovirt.org
>> >>>> http://lists.ovirt.org/mailman/listinfo/devel
>> >>
>> >>
>> >>
>> >>
>> >> --
>> >> Sandro Bonazzola
>> >> Better technology. Faster innovation. Powered by community
>> collaboration.
>> >> See how it works at redhat.com
>> >>
>> >> _______________________________________________
>> >> Devel mailing list
>> >> Devel at ovirt.org
>> >> http://lists.ovirt.org/mailman/listinfo/devel
>> > _______________________________________________
>> > Devel mailing list
>> > Devel at ovirt.org
>> > http://lists.ovirt.org/mailman/listinfo/devel
>> >
>> >
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20161124/e2e40bb4/attachment-0001.html>