[ovirt-devel] [VDSM] build-artifacts failing on master

[Nir Soffer]

The build-artifacts job is failing on master now with this error:

19:09:23 Error: NOSE is too old, please install NOSE 1.3.7 or later
19:09:23 make[1]: *** [tests] Error 1
19:09:23 make[1]: Leaving directory
`/home/jenkins/workspace/vdsm_master_build-artifacts-el7-x86_64/vdsm/rpmbuild/BUILD/vdsm-4.18.999'
19:09:23 error: Bad exit status from /var/tmp/rpm-tmp.LQXOfm (%check)
19:09:23
19:09:23
19:09:23 RPM build errors:
19:09:23     Bad exit status from /var/tmp/rpm-tmp.LQXOfm (%check)

Looks like this patch is the cause:

commit 4e729ddd2b243d0953e2de5d31c42fc59859bf23
Author: Edward Haas <edwardh at redhat.com>
Date:   Sun Sep 11 14:10:01 2016 +0300

    build tests: Require NOSE 1.3.7 and up for running tests

    On RHEL7/Centos7 the provided NOSE version is 1.3.0.
    CI runs the tests with 1.3.7.

    To be consistent and avoid different behaviours, assure that the tests
    are running with a minimum nose version of 1.3.7.

    Specifically, between 1.3.0 and 1.3.7 a bug has been resolved regarding
    test labeling and its support with test class inheritance.

    Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
    Signed-off-by: Edward Haas <edwardh at redhat.com>
    Reviewed-on: https://gerrit.ovirt.org/63638
    Continuous-Integration: Jenkins CI
    Reviewed-by: Petr Horáček <phoracek at redhat.com>
    Reviewed-by: Irit Goihman <igoihman at redhat.com>
    Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
    Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>

I did not check the details, but it seems we need to revert this patch.

Please check and fix.

Cheers,
Nir