[ovirt-devel] PatternFly upgrade - how to handle JS dependencies

[Martin Perina]

On Fri, Jan 6, 2017 at 6:45 PM, Vojtech Szocs <vszocs at redhat.com> wrote:

> Hello,
>
> we'd like to upgrade the version of PatternFly (plus associated libraries,
> namely Bootstrap and jQuery) used in oVirt UI.
>
> Today, PatternFly stuff (PF + associated libraries) comes from
> `patternfly1`
> package hosted at Copr repo:
>
>   https://copr.fedorainfracloud.org/coprs/patternfly/patternfly1/
>
> Today, we require `patternfly1` as both Engine RPM build dependency and the
> Engine devel. env. dependency.
>
> To keep things simple, I'd like to propose the following approach:
>
> - create oVirt specific package, e.g. `ovirt-patternfly`, hosted at Copr,
>   containing PatternFly + associated libraries (Bootstrap, jQuery) which
>   are intended *specifically* for use by oVirt UI (hence the ovirt prefix)
>
> - discontinue maintenance of `patternfly1` package at Copr
>
> - keep the existing approach: require `ovirt-patternfly` as both the Engine
>   build dependency and the Engine devel. env. dependency
>

​+1 from me.

The only issue is that we combine several javascript libraries in a package
named ovirt-patternfly. Is there a high probabily that we will need some
other javascript libraries in near future? If so, then I'd rather call the
package ovirt-javascript-dependencies (or ovirt-js-dependencies).
​


>
> An alternative approach would be to introduce Node.js as Engine devel. env.
> dependency (use `npm install` to pull PF stuff), while using the existing
> ovirt-engine-{nodejs,nodejs-modules} packages for Engine RPM build.
>
> However, this alternative has some downsides, namely complication of devel.
> env. just to fetch the PF stuff. I don't like the idea of complicating the
> existing devel. env. just for the sake of fetching some 3rd party libs.
>
> I'm wondering what others think about this.
>
> Regards,
> Vojtech
> _______________________________________________
> Devel mailing list
> Devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20170106/4d6fcf1f/attachment.html>