[ovirt-devel] PatternFly upgrade - how to handle JS dependencies

[Vojtech Szocs]

----- Original Message -----
> From: "Sven Kieske" <s.kieske at mittwald.de>
> To: devel at ovirt.org
> Sent: Saturday, January 7, 2017 5:01:37 PM
> Subject: Re: [ovirt-devel] PatternFly upgrade - how to handle JS dependencies
> 
> On 06/01/17 18:45, Vojtech Szocs wrote:
> > Today, we require `patternfly1` as both Engine RPM build dependency and the
> > Engine devel. env. dependency.
> > 
> > To keep things simple, I'd like to propose the following approach:
> > 
> > - create oVirt specific package, e.g. `ovirt-patternfly`, hosted at Copr,
> >   containing PatternFly + associated libraries (Bootstrap, jQuery) which
> >   are intended *specifically* for use by oVirt UI (hence the ovirt prefix)
> > 
> > - discontinue maintenance of `patternfly1` package at Copr
> 
> afaik you're also requiring patternfly1 for ovirt-engine installation,
> not just dev or build env?

Sven, you are correct.

Today, `patternfly1` is needed at Engine RPM install-time (via Requires)
and as Engine devel. env. pre-requisite.

It's not needed at Engine RPM build-time (no BuildRequires). Apologies
for confusion. I realized it after I sent my mail..

> 
> if that is correct and your new "ovirt-patternfly" would superseed that
> I'm afraid you would violate fedora and rhel/centos package guidelines
> by throwing this all together in one package?

The newly proposed package should be oVirt-specific, for oVirt by oVirt.
It's not meant to be a general-purpose RPM containing PatternFly stuff.

Is it a violation of Fedora pkg guidelines if a project creates its own
package, bundling 3rd party dependencies?

> 
> I hope I understood the scope of this correct, if not, just disregard my
> comment.
> 
> --
> Mit freundlichen Grüßen / Regards
> 
> Sven Kieske
> 
> Systemadministrator
> Mittwald CM Service GmbH & Co. KG
> Königsberger Straße 6
> 32339 Espelkamp
> T: +495772 293100
> F: +495772 293333
> https://www.mittwald.de
> Geschäftsführer: Robert Meyer
> St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen
> Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen
> 
> 
> _______________________________________________
> Devel mailing list
> Devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel