[ovirt-devel] Who cares about 'memGuaranteedSize'?

[Martin Sivak]

Hi Francesco,

MOM is using it via the balloon_min key in balloonInfo. The policy
that does that is part of the vdsm package though:

https://gerrit.ovirt.org/gitweb?p=vdsm.git;a=blob;f=static/etc/vdsm/mom.d/02-balloon.policy;h=b1af0d5833619042d8d9f023905efb59a99f2041;hb=209d37b60f55461a80bf0115cdf411c5c1b6e475#l129

Best regards

Martin

On Thu, Jun 8, 2017 at 9:28 AM, Francesco Romani <fromani at redhat.com> wrote:
> Hi all,
>
>
> We have this field in the Vdsm API:
>
>
>         -   description: The amount of memory guaranteed to the VM in MB
>             name: memGuaranteedSize
>             type: uint
>
>
> Available in     VmDefinition, VMFullInfo, VmParameters
>
>
> Vdsm dutifully records and reports this value - but doesn't use it. It
> is used exactly once for balloon stata:
>
>
>         stats['balloonInfo'].update({
>             'balloon_max': str(max_mem),
>             'balloon_min': str(
>                 int(vm.conf.get('memGuaranteedSize', '0')) * 1024),
>             'balloon_cur': str(balloon_cur),
>             'balloon_target': str(balloon_target)
>         })
>
>
> Now, a quick git grep in both MOM and Engine reveals no obvious usages.
> Am I missing something?
>
> Can we drop this for 4.2, and deprecate it in next(4.1) ?
>
>
> Thanks,
>
> --
> Francesco Romani
> Senior SW Eng., Virtualization R&D
> Red Hat
> IRC: fromani github: @fromanirh
>
> _______________________________________________
> Devel mailing list
> Devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel