[ovirt-devel] oVirt Engine checkstyle upgrade

[Vojtech Szocs]

Hi Allon,

I think I found some strange Checkstyle related problems on master.

Engine build with (GWT compilation enabled) works OK.

Next, trying to start GWT debugger:

$ make gwt-debug DEBUG_MODULE=webadmin \
  DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS="-Dgwt.userAgent=gecko1_8,safari" \
  DEV_EXTRA_BUILD_FLAGS="-Dgwt.logLevel=INFO -Dgwt.locale=en_US
-Dgwt.compiler.localWorkers=1" \
  DEV_BUILD_GWT_SUPER_DEV_MODE=1

maven-checkstyle-plugin:check execution fails on


frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/FormatterDotnet.java
  can't parse argument number: (\\d)\\: For input string: "(\\d)\\"

the class isn't used, removed it, retry. Now it fails on:


frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/slf4j/Logger.java
  can't parse argument number: For input string: ""

I guess it's a bug in our NON-NLS check? But why doesn't the problem occur
during Engine build?

I'm thinking about disabling Checkstyle for gwt-extension module, as it
contains custom GWT RPC serializers and GWT class overrides, and maybe the
file path
src/main/java/org/ovirt/engine/ui/uioverrides/here/goes/actual/pkg is
confusing the Checkstyle now.

Thanks,
Vojtech


On Wed, Mar 22, 2017 at 10:33 PM, Allon Mureinik <amureini at redhat.com>
wrote:

> Hi all,
>
> As per [1], I've just merged a series of patches that upgrades the oVirt
> engine to use the latest maven-checkstyle-plugin and checkstyle packages.
>
> Please note that the newer checkstyle is a tad stricter than the old one
> we used to have (read: it contains several fixes for bugs where the old
> checkstyle was supposed to find issues but missed them).
> I also took the opportunity and added a couple of new checks that enforce
> rules we were de-facto adhering to anyway.
>
> If any problems come up, please let me know.
>
>
> -Your friendly neighborhood cleanup dude
>
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1433408
>
> _______________________________________________
> Devel mailing list
> Devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20170324/248cd612/attachment.html>