[ovirt-devel] oVirt Engine checkstyle upgrade

[Vojtech Szocs]

On Tue, Mar 28, 2017 at 3:56 PM, Shmuel Melamud <smelamud at redhat.com> wrote:

> Hi!
>
> > Well, whenever I see:
> >
> >   class Foo {
> >     int a;
> >     void bar() {
> >     }
> >
> >   }
> >
> > it hurts my eyes because there's no symmetry - whitespace before class
> > declaration end, but no whitespace after class declaration start.
>
> Yes. And the same in this case:
>
> class Foo {
>
>     int a;
>     void bar() {
>     }
> }
>
> Personally I'd like to force this symmetry with checkstyle rules, but
> I know many don't agree with me ;)
>

​Well, I agree with you.

Some people don't care about stylistic issues, however with things like
above enforced, it reduces the variance (e.g. related to whitespace usage)
and consequently makes the code look more consistent.


>
> Shmuel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20170328/858c45e4/attachment.html>