[ovirt-devel] VmIconDaoTest compiling error

shubham dubey sdubey504 at gmail.com
Tue May 23 06:25:26 UTC 2017 

I have just cloned the whole engine again and do the fresh changes in that.
It was little extra work but it worth since the error disappear.

I have also pushed the changes https://gerrit.ovirt.org/#/c/77142/

Thanks,
Shubham

On Tue, May 23, 2017 at 12:55 AM, shubham dubey <sdubey504 at gmail.com> wrote:

> Ok, I will push the changes in gerrit. And Yes, I have created a new db
> script.
>
> On 23 May 2017 12:51 a.m., "Martin Perina" <mperina at redhat.com> wrote:
>
>>
>>
>> On Mon, May 22, 2017 at 9:12 PM, shubham dubey <sdubey504 at gmail.com>
>> wrote:
>>
>>> If you want to see the files I have changed then they are as same as
>>> done in this push https://gerrit.ovirt.org/#/c/63097/.
>>>
>>
>> ​Please push your patch to gerrit and share, otherwise we can only guess
>> about the issue.
>>
>> Btw you should definitely not have the same db upgrade script in your
>> patch (as you said you performed changes in the same files as above patch).
>> If you are doing some changes in db, then you need new db script starting
>> with 04_02 prefix
>>
>> Martin
>> ​
>>
>>
>>>
>>>
>>> On 23 May 2017 12:36 a.m., "shubham dubey" <sdubey504 at gmail.com> wrote:
>>>
>>>> No, my changes are related to storage domain (adding new flag in
>>>> storage domain db entries). I have done some changes in unit tests dao
>>>> files to test those changes only but nothing related to icon.
>>>>
>>>> On 23 May 2017 12:14 a.m., "Greg Sheremeta" <gshereme at redhat.com>
>>>> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Mon, May 22, 2017 at 2:34 PM, shubham dubey <sdubey504 at gmail.com>
>>>>> wrote:
>>>>>
>>>>>> I have done some changes
>>>>>>
>>>>>
>>>>> What did you change?
>>>>>
>>>>>
>>>>>> in ovirt-engine now while compiling I am getting following error in
>>>>>> file
>>>>>> VmIconDaoTest.
>>>>>>
>>>>>> Tests run: 13, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
>>>>>> 2.466 sec <<< FAILURE!
>>>>>> testGetVmIconByDataUrlWithValidUrl(org.ovirt.engine.core.dao.VmIconDaoTest)
>>>>>> Time elapsed: 18 sec  <<< FAILURE!
>>>>>> java.lang.AssertionError: expected:<1> but was:<0>
>>>>>>         at org.junit.Assert.fail(Assert.java:88)
>>>>>>         at org.junit.Assert.failNotEquals(Assert.java:834)
>>>>>>         at org.junit.Assert.assertEquals(Assert.java:645)
>>>>>>         at org.junit.Assert.assertEquals(Assert.java:631)
>>>>>>         at org.ovirt.engine.core.dao.VmIc
>>>>>> onDaoTest.testGetVmIconByDataUrlWithValidUrl(VmIconDaoTest.java:59)
>>>>>>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
>>>>>> Method)
>>>>>>         at sun.reflect.NativeMethodAccess
>>>>>> orImpl.invoke(NativeMethodAccessorImpl.java:62)
>>>>>>         at sun.reflect.DelegatingMethodAc
>>>>>> cessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>>>>>>         at java.lang.reflect.Method.invoke(Method.java:498)
>>>>>>         at org.junit.runners.model.Framew
>>>>>> orkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>>>>>>         at org.junit.internal.runners.mod
>>>>>> el.ReflectiveCallable.run(ReflectiveCallable.java:12)
>>>>>>         at org.junit.runners.model.Framew
>>>>>> orkMethod.invokeExplosively(FrameworkMethod.java:47)
>>>>>>         at org.junit.internal.runners.sta
>>>>>> tements.InvokeMethod.evaluate(InvokeMethod.java:17)
>>>>>>         at org.junit.internal.runners.sta
>>>>>> tements.RunBefores.evaluate(RunBefores.java:26)
>>>>>>         at org.springframework.test.conte
>>>>>> xt.junit4.statements.RunBeforeTestMethodCallbacks.evaluate(R
>>>>>> unBeforeTestMethodCallbacks.java:75)
>>>>>>         at org.springframework.test.conte
>>>>>> xt.junit4.statements.RunAfterTestMethodCallbacks.evaluate(Ru
>>>>>> nAfterTestMethodCallbacks.java:86)
>>>>>>         at org.springframework.test.conte
>>>>>> xt.junit4.statements.SpringRepeat.evaluate(SpringRepeat.java:84)
>>>>>>         at org.junit.runners.ParentRunner
>>>>>> .runLeaf(ParentRunner.java:325)
>>>>>>         at org.springframework.test.conte
>>>>>> xt.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4Class
>>>>>> Runner.java:254)
>>>>>>         at org.springframework.test.conte
>>>>>> xt.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4Class
>>>>>> Runner.java:89)
>>>>>>         at org.junit.runners.ParentRunner
>>>>>> $3.run(ParentRunner.java:290)
>>>>>>         at org.junit.runners.ParentRunner
>>>>>> $1.schedule(ParentRunner.java:71)
>>>>>>         at org.junit.runners.ParentRunner
>>>>>> .runChildren(ParentRunner.java:288)
>>>>>>         at org.junit.runners.ParentRunner
>>>>>> .access$000(ParentRunner.java:58)
>>>>>>         at org.junit.runners.ParentRunner
>>>>>> $2.evaluate(ParentRunner.java:268)
>>>>>>         at org.junit.internal.runners.sta
>>>>>> tements.RunBefores.evaluate(RunBefores.java:26)
>>>>>>         at org.springframework.test.conte
>>>>>> xt.junit4.statements.RunBeforeTestClassCallbacks.evaluate(Ru
>>>>>> nBeforeTestClassCallbacks.java:61)
>>>>>>         at org.springframework.test.conte
>>>>>> xt.junit4.statements.RunAfterTestClassCallbacks.evaluate(Run
>>>>>> AfterTestClassCallbacks.java:70)
>>>>>>         at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>>>>>>         at org.springframework.test.conte
>>>>>> xt.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunne
>>>>>> r.java:193)
>>>>>>         at org.apache.maven.surefire.juni
>>>>>> t4.JUnit4Provider.execute(JUnit4Provider.java:252)
>>>>>>         at org.apache.maven.surefire.juni
>>>>>> t4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
>>>>>>         at org.apache.maven.surefire.juni
>>>>>> t4.JUnit4Provider.invoke(JUnit4Provider.java:112)
>>>>>>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
>>>>>> Method)
>>>>>>         at sun.reflect.NativeMethodAccess
>>>>>> orImpl.invoke(NativeMethodAccessorImpl.java:62)
>>>>>>         at sun.reflect.DelegatingMethodAc
>>>>>> cessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>>>>>>         at java.lang.reflect.Method.invoke(Method.java:498)
>>>>>>         at org.apache.maven.surefire.util
>>>>>> .ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
>>>>>>         at org.apache.maven.surefire.boot
>>>>>> er.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
>>>>>>         at org.apache.maven.surefire.boot
>>>>>> er.ProviderFactory.invokeProvider(ProviderFactory.java:85)
>>>>>>         at org.apache.maven.surefire.boot
>>>>>> er.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
>>>>>>         at org.apache.maven.surefire.boot
>>>>>> er.ForkedBooter.main(ForkedBooter.java:75)
>>>>>>
>>>>>> ...
>>>>>> ...
>>>>>> Failed tests:   testGetVmIconByDataUrlWithVali
>>>>>> dUrl(org.ovirt.engine.core.dao.VmIconDaoTest): expected:<1> but
>>>>>> was:<0>
>>>>>>
>>>>>> I haven't even done any change in VmIconDaoTest file but this error
>>>>>> is there.
>>>>>> I even try to change the value result.get(0) to result.get(1) in
>>>>>> testGetVmIconByDataUrlWithValidUrl but that didn't work.
>>>>>>
>>>>>
>>>>> This is a "unit test." It's rare that you'd want to change it. Its
>>>>> purpose it to inform you that you've probably broken something somewhere
>>>>> else -- likely in the very thing this test is testing, aka the "unit." By
>>>>> the test that's failing, I'd guess that you've changed some code around the
>>>>> Icons feature.
>>>>>
>>>>> Greg
>>>>>
>>>>>
>>>>>
>>>>>>
>>>>>>
>>>>>> Thanks in advance.
>>>>>>
>>>>>> Shubham
>>>>>>
>>>>>> _______________________________________________
>>>>>> Devel mailing list
>>>>>> Devel at ovirt.org
>>>>>> http://lists.ovirt.org/mailman/listinfo/devel
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Greg Sheremeta, MBA
>>>>> Sr. Software Engineer
>>>>> Red Hat, Inc.
>>>>> gshereme at redhat.com
>>>>>
>>>>
>>> _______________________________________________
>>> Devel mailing list
>>> Devel at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/devel
>>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20170523/d08c86b9/attachment.html>

More information about the Devel mailing list