[ovirt-devel] Why we don't call "blockPull" to merge snapshot(base to top) in vdsm?

[pengyixiang]

hello, everyone!
      We create a snapshot chain as follows map [1], if we delete "Snapshot1", it will call [2] in vdsm, in last, "virsh blockcommit' will be called,
but if we delete "Snapshot2", it will call [3] in vdsm, at last we will call [4], it use qemu.cmd "commit". , why we don't use "virsh blockpull" to merge snapshot to topVolume?
is qemu.cmd "commit" better?








[1]


[2] https://github.com/oVirt/vdsm/blob/2b98daffb2c2dec1bbbd3427d3d32861d77f01a7/lib/vdsm/virt/vm.py#L5744


[3] https://github.com/oVirt/vdsm/blob/98e6a5d1ad1b097b9c993dca33372f970a3adce4/lib/vdsm/API.py#L1655
[4] https://github.com/oVirt/vdsm/blob/98e6a5d1ad1b097b9c993dca33372f970a3adce4/lib/vdsm/storage/qemuimg.py#L218










 





 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20180118/b636f985/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 4980 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20180118/b636f985/attachment.png>