Change in ovirt-guest-agent[master]: Fixed support for reporting devices with only ipv6.

bazulay at redhat.com bazulay at redhat.com
Mon Dec 24 14:52:02 UTC 2012


Barak Azulay has submitted this change and it was merged.

Change subject: Fixed support for reporting devices with only ipv6.
......................................................................


Fixed support for reporting devices with only ipv6.

ethtool.get_active_devices does not consider as up the devices that
have only an IPv6 address set. Also, it throws an IOError exception
when doing get_ipaddr of a device that is up but does not have an
IPv4 address set. Thus, doing the filtering by using the device flags
and getting the IPv4 address in a similar way as how we get the IPv6
one, not only fixes the issue but increases the consistency of the
code.

Change-Id: I92010740da24bb30c7316c268c704d9067b28aae
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
---
M ovirt-guest-agent/GuestAgentLinux2.py
1 file changed, 11 insertions(+), 5 deletions(-)

Approvals:
  Barak Azulay: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/10223
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I92010740da24bb30c7316c268c704d9067b28aae
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>



More information about the Engine-commits mailing list