Change in ovirt-engine[master]: core: [RFE] Display of both the console user and the guest u...

ofrenkel at redhat.com ofrenkel at redhat.com
Wed Dec 26 10:13:25 UTC 2012


Omer Frenkel has submitted this change and it was merged.

Change subject: core: [RFE] Display of both the console user and the guest user
......................................................................


core: [RFE] Display of both the console user and the guest user

In 3.0 we displayed the guest logged-in user in the engine. In 3.1 we display
the console user instead. This patch makes the engine to display both of these
values.

- removed guest_user_id column from vm_dynamic table (it is not used) and
  corresponding field in entities (VM, VmDynamic)
- added new column console_cur_user_name and a corresponding field in the
  entities (VM, VmDynamic)
- NOTE: the semantics of existing guest_cur_user_name of VmDynamic is changed
  to its original state (as in 3.0 - the value is reported by GA), the console
  user name will be tracked in the console_cur_user_name, which makes more
  sense
- removed VmLogoffCommand which has not been used
- added new command UpdateVmConsoleDataCommand Vm console data
- vdsbroker package - changed behavior so that guest logged-in user information
  is not discarded

Change-Id: Icd5b178402b32435ceb79120ea1e411f0cc83606
Signed-off-by: Frantisek Kobzik <fkobzik at redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=879586
---
M backend/manager/dbscripts/create_views.sql
A backend/manager/dbscripts/upgrade/03_02_0150_add_console_cur_user_name.sql
A backend/manager/dbscripts/upgrade/03_02_0160_drop_guest_user_id_column.sql
M backend/manager/dbscripts/vms_sp.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmConsoleDataCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogoffCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogonCommand.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVmConsoleDataParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/UpdateVmDynamicDataVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
20 files changed, 132 insertions(+), 132 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/10219
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icd5b178402b32435ceb79120ea1e411f0cc83606
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>



More information about the Engine-commits mailing list