Change in ovirt-engine[master]: core: ReconstructMasterDomain -connect/disconnect hosts simu...

tnisan at redhat.com tnisan at redhat.com
Mon Dec 31 16:07:57 UTC 2012


Tal Nisan has submitted this change and it was merged.

Change subject: core: ReconstructMasterDomain -connect/disconnect hosts simultaneously
......................................................................


core: ReconstructMasterDomain -connect/disconnect hosts simultaneously

When running ReconstructMasterDomain/RecoveryStoragePool commands - any
connect/disconnect operations can be done simultaneously by different
threads in order to improve the runtime.

There's no need to make use here of the runSynchronizeOperation() ,
it will require to add few classes, handle with parameter passing when
this flow is relevant to the Reconstruct flow, in many places in the
code we execute runnables using ThreadPoolUtils class so I prefer to
keep the implementation simple rather then complicate it and add classes that
will be never used again just to use CountDownLatch.

Change-Id: I3c8dac368d60eac85a92762dffc5dbb8062b85ef
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
1 file changed, 52 insertions(+), 39 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/10117
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3c8dac368d60eac85a92762dffc5dbb8062b85ef
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list