Change in ovirt-engine[master]: core: Fixing addSubStep at CommandBase

[yzaslavs at redhat.com]

Yair Zaslavsky has submitted this change and it was merged.

Change subject: core: Fixing addSubStep at CommandBase
......................................................................


core: Fixing addSubStep at CommandBase

A subStep should added also in case there is no job associated with the command.
This can happen when a child command is created, and the job from the parent command
was not propagated to it.
This happens for example during AttachUserToVmFromPoolAndRunCommand -
When creating an execution context for child command, it is required to set the step.
However, the job identifies only the parent command that was invoked by the client.
Adding a sub step on steps that are created by the parent command will create NPE
if there will be an attempt to get the parent step from the job. This patch fixes
this issue.

Signed-off-by: Yair Zaslavsky <yzaslavs at redhat.com>

Change-Id: I0def5f5ffb896ee946ff3472af92c86074977ed1
Signed-off-by: Yair Zaslavsky <yzaslavs at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Eli Mesika: Looks good to me, approved
  Yair Zaslavsky: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5836
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0def5f5ffb896ee946ff3472af92c86074977ed1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>