Change in ovirt-engine[master]: engine: Fetching cluster Id code moved from constructor to c...

ofrenkel at redhat.com ofrenkel at redhat.com
Mon Jul 23 07:02:26 UTC 2012


Omer Frenkel has submitted this change and it was merged.

Change subject: engine: Fetching cluster Id code moved from constructor to canDoAction method.
......................................................................


engine: Fetching cluster Id code moved from constructor to canDoAction method.

It is difficult to write test case without static mocking,
because the code uses DbFacade from constructor.
Hence it is moved to canDoAction.

Change-Id: I187f4fa678389dbbd271d487bbbf2b81e5c0080c
Signed-off-by: Selvasundaram <sesubram at redhat.com>
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeCommandBase.java
1 file changed, 6 insertions(+), 7 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, but someone else must approve
  Omer Frenkel: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/6365
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I187f4fa678389dbbd271d487bbbf2b81e5c0080c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesubram at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Selvasundaram <sesubram at redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal at redhat.com>



More information about the Engine-commits mailing list