Change in ovirt-engine[master]: core: make VmBase.isoPath default to empty string

rgolan at redhat.com rgolan at redhat.com
Tue Jun 5 07:38:13 UTC 2012


Roy Golan has submitted this change and it was merged.

Change subject: core: make VmBase.isoPath default to empty string
......................................................................


core: make VmBase.isoPath default to empty string

making the VmBase property isoPath to an empty string is defensive coding
against creation of null values when building an XmlRpcStruct which will result exceptions
and not being able to run actions against VDSM.

while the fix is small, the real solution is to get rid of isoPath since
we have cd information kept in vm_devices already.

Change-Id: I1dc98767943ddfbc18884d87c22e1f1634bc4b65
Signed-off-by: Roy Golan <rgolan at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Roy Golan: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5052
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1dc98767943ddfbc18884d87c22e1f1634bc4b65
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>



More information about the Engine-commits mailing list