Change in ovirt-engine[master]: webadmin: Main tab presenter reveal bound to model availabil...

gchaplik at redhat.com gchaplik at redhat.com
Mon May 21 13:52:13 UTC 2012


Gilad Chaplik has submitted this change and it was merged.

Change subject: webadmin: Main tab presenter reveal bound to model availability
......................................................................


webadmin: Main tab presenter reveal bound to model availability

This patch makes sure that main tab presenters (AbstractMainTabPresenter)
can only be revealed if the corresponding main model is available.

Besides tab widgets (ModelBoundTab) sensitive to main model availability,
this makes sure that users cannot access restricted main tabs even if they
manipulate browser URL (which initiates GWTP place navigation and presenter
reveal process).

Change-Id: I822f14bc4cde42cfed646206b63a76345ec583a3
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java
2 files changed, 35 insertions(+), 9 deletions(-)

Approvals:
  Gilad Chaplik: Looks good to me, approved
  Vojtech Szocs: Verified


--
To view, visit http://gerrit.ovirt.org/4622
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I822f14bc4cde42cfed646206b63a76345ec583a3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>



More information about the Engine-commits mailing list