Change in ovirt-engine[master]: webadmin: [setupNetworks] Unsync net params can be changed (...

alkaplan at redhat.com alkaplan at redhat.com
Sun Sep 2 15:58:16 UTC 2012


Alona Kaplan has submitted this change and it was merged.

Change subject: webadmin: [setupNetworks] Unsync net params can be changed (#848354)
......................................................................


webadmin: [setupNetworks] Unsync net params can be changed (#848354)

https://bugzilla.redhat.com/848354

The bug was fixed in a previous commit, but the fix worked just in
case the "is to sync" was checked an unchecked without closing the
dialog.
If the edit network dialog is colsed and then opened again and
the "is to sync" is changed back to false. The original "before sync"
values should be reverted- this didn't work in the prevoius commit.


Change-Id: Ia00641b123f109d443d98e2c99e727099c2a9d16
Signed-off-by: Alona Kaplan <alkaplan at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NetworkParameters.java
4 files changed, 30 insertions(+), 25 deletions(-)

Approvals:
  Alona Kaplan: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7684
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia00641b123f109d443d98e2c99e727099c2a9d16
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>



More information about the Engine-commits mailing list