Change in ovirt-engine[master]: webadmin: Edit pool hangs when the pool has no VMs (#852297)

[ecohen at redhat.com]

Einav Cohen has submitted this change and it was merged.

Change subject: webadmin: Edit pool hangs when the pool has no VMs (#852297)
......................................................................


webadmin: Edit pool hangs when the pool has no VMs (#852297)

https://bugzilla.redhat.com/852297

When the pool has no VMs, it makes no sense to have the pool
itself.

This patch adds a behavior, that when the user detaches all the VMs
from the pool, show a message to the user, and when the
user approves this operation, it deletes the pool itself.

The pool is deleted in the RemoveVmFromPoolRunner using the
RemoveVmPoolCommand when there is no more VMs left in the
pool and the operation is explicitly enabled by
removePoolUponDetachAllVMs parameter on the
RemoveVmFromPoolParameters.

Change-Id: I3b8f47e6dd5ce8149ba78c7c25455997b3bf62eb
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunnersFactory.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromPoolRunner.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmFromPoolParameters.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/gwtservices/GenericApiGWTService.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolVmListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/PoolModule.java
8 files changed, 133 insertions(+), 40 deletions(-)

Approvals:
  Einav Cohen: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7583
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3b8f47e6dd5ce8149ba78c7c25455997b3bf62eb
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server