Change in ovirt-engine[master]: packaging: support edit config file in "uncomment" mode

yzaslavs at redhat.com yzaslavs at redhat.com
Sun Sep 30 03:27:00 UTC 2012


Yair Zaslavsky has submitted this change and it was merged.

Change subject: packaging: support edit config file in "uncomment" mode
......................................................................


packaging: support edit config file in "uncomment" mode

Currently comment lines are ignored, and new values are added
at the bottom of the file.

This breaks apache configuration which needs configuration to be
specified in designated blocks.

Luckily, apache provides commented keys, so we can use these as
template.

Change-Id: I6bc9b90b929315848aaeca10d8b1bc795938ab71
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M packaging/fedora/setup/common_utils.py
M packaging/fedora/setup/engine-setup.py
2 files changed, 45 insertions(+), 16 deletions(-)

Approvals:
  Yair Zaslavsky: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/8269
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6bc9b90b929315848aaeca10d8b1bc795938ab71
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list