Change in ovirt-engine[master]: webadmin: Display correct error when adding new storage

tnisan at redhat.com tnisan at redhat.com
Tue Apr 9 14:13:38 UTC 2013


Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: Display correct error when adding new storage
......................................................................


webadmin: Display correct error when adding new storage

When adding a new Storage Domain (of NFS/Local type) the error displayed
when the connection was failed was always "Error creating a storage domain"
instead of the actual error from VDSM (no permission error etc.), the connect
command was changed to propegated the VDSM error to the client there it will
be tranlsated and be displayed as the translated user friendly value

Change-Id: Ib8f721d3f10596253ca194a36139ba9ebcdff246
Bug-Url: https://bugzilla.redhat.com/843440
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
4 files changed, 20 insertions(+), 4 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13681
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8f721d3f10596253ca194a36139ba9ebcdff246
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list