Change in ovirt-engine[master]: core: pre processing for search-generated ldap filters

[yzaslavs at redhat.com]

Yair Zaslavsky has submitted this change and it was merged.

Change subject: core: pre processing for search-generated ldap filters
......................................................................


core: pre processing for search-generated ldap filters

The search generates a uniform ldap uery in format that contains
upper case keys with $ sign before them - for example
($PRINCIPAL_NAME=a at ovirt.org)

In case of open ldap and RHDS, principal name (i.e - user at domain)
should not be passed to the ldap server as the ldap query
that is being generated uses the "uid" attribute which is based on
user name and not UPN.
Furthermore, at least some of the versions of RHDS, and open ldap do
not contain support for UPN upon out of the box installation.

Instead of passing the UPN to the query, it should be split, and the
ldap query should be run
with a filter that contains only the user part.

Change-Id: I35744eb423ca7f553bf7e9b20c72179bca4e6827
Bug-Url: https://bugzilla.redhat.com/991800
Signed-off-by: Yair Zaslavsky <yzaslavs at redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapFilterSearchEnginePreProcessor.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryMetadataFactoryImpl.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/NoOpLdapFilterSearchEnginePreProcessor.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/SearchQueryFotmatter.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/UpnSplitterLdapFilterSearchEnginePreProcessor.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/LdapFilterSearchEnginePreProcessorTest.java
6 files changed, 92 insertions(+), 11 deletions(-)

Approvals:
  Yair Zaslavsky: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/17794
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I35744eb423ca7f553bf7e9b20c72179bca4e6827
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server