Change in ovirt-engine[master]: frontend: pool dialog templates not updated according to DC

vszocs at redhat.com vszocs at redhat.com
Thu Aug 22 13:03:48 UTC 2013


Vojtech Szocs has submitted this change and it was merged.

Change subject: frontend: pool dialog templates not updated according to DC
......................................................................


frontend: pool dialog templates not updated according to DC

If the DC has been changed the templates have not been updated.
There were two issues which caused this:

1: the list of templates has not been updated after the DC has been
   changed

2: the ListModelTypeAheadListBox handled the setValue() differently
   than other ListModelListBox. The ListModelListBox if gets a
   value in setValue() which is not part of the acceptable values
   adds it as one of them (in ValueListBox.updateListBox()).
   The ListModelTypeAheadListBox have ignored this values as incorrect
   ones. The problem is that UiCommonEditorVisitor first calls the
   setValue() and then the setAcceptableValues() which works correctly
   only the first time. Fixed by aligning the ListModelTypeAheadListBox
   to work the same as the ListModelListBox.

Bug-Url: https://bugzilla.redhat.com/987819
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
Change-Id: I0ab81ee7165f9855de3d843fcf7ead0fc3db512a
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java
2 files changed, 11 insertions(+), 16 deletions(-)

Approvals:
  Vojtech Szocs: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/18171
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0ab81ee7165f9855de3d843fcf7ead0fc3db512a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list