Change in ovirt-engine[master]: core: remove MigrateVmCommand#canMigrateVm

ofrenkel at redhat.com ofrenkel at redhat.com
Tue Aug 27 13:50:38 UTC 2013


Omer Frenkel has submitted this change and it was merged.

Change subject: core: remove MigrateVmCommand#canMigrateVm
......................................................................


core: remove MigrateVmCommand#canMigrateVm

All that MigrateVmCommand#canDoAction was doing was to delegate to
canMigrateVm method and canMigrateVm method was not called from anywhere
else. Thus, this patch removes the canMigrateVm method and put its body
in the canDoAction method instead.

InternalMigrateVmCommand is also changed accordingly.

Change-Id: If88012b8bdbc7d23ad9350acf207431727e1d51e
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
2 files changed, 11 insertions(+), 13 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/18468
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If88012b8bdbc7d23ad9350acf207431727e1d51e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list